fix: set build-backend in pyproject.toml#1455
Merged
jdavid merged 1 commit intolibgit2:masterfrom Mar 19, 2026
Merged
Conversation
Remove wheel from build requirements and add proper build-backend per PEP 517. This fixes the issue where pip install would not use build isolation properly. Fixes libgit2#1452
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
wheelfrom build requirements and add properbuild-backend = "setuptools.build_meta"per PEP 517.Problem
Issue #1452 points out that the current
pyproject.tomlis missing thebuild-backendsetting. Without it, pip uses legacy build behavior which causes issues.Fix
wheelfrom[build-system].requires(it's no longer needed as it's now part of setuptools)build-backend = "setuptools.build_meta"to enable proper PEP 517 build isolationTesting
This is a configuration-only change. The fix follows PEP 517 and setuptools documentation.
Closes #1452