-
Notifications
You must be signed in to change notification settings - Fork 2k
Addition of missing class codes #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| LIBUSB_CLASS_PERSONAL_HEALTHCARE = 0x0f, | ||
|
|
||
| /** Audio & Video */ | ||
| LIBUSB_CLASS_AUDIO_VIDEO = 0x10, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look like indented 1 space too much...
|
|
||
| /** I3C */ | ||
| LIBUSB_CLASS_I3C = 0x3c, | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order this correctly, before 0xdc.
| LIBUSB_CLASS_BILLBOARD = 0x11, | ||
|
|
||
| /** Interface class */ | ||
| LIBUSB_CLASS_INTERFACE = 0x12, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you maybe look at the wrong column here?
USB Type-C Bridge Class
tormodvolden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With some fixups this looks good.
According to the documents a couple of class codes are missing (reference: www.usb.org/defined-class-codes).
This pull request is related to issue #1716.