Update rust-lightning to b6c17c593a and fix breaking API changes#789
Update rust-lightning to b6c17c593a and fix breaking API changes#789tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
Bump rust-lightning from 817ab5e583 to b6c17c593a and
bitcoin-payment-instructions to ea50a9d2a8.
Adapt to upstream breaking changes:
- `UserConfig::manually_accept_inbound_channels` was removed; manual
acceptance is now the default and only behavior, so the explicit
assignment is dropped.
- `InvoiceBuilder::payment_hash()` now takes the unified `PaymentHash`
type directly, removing the need for the `lightning_invoice::PaymentHash`
wrapper and the `sha256`/`Hash` imports in liquidity.rs.
- `BroadcasterInterface::broadcast_transactions` now takes
`&[(&Transaction, TransactionType)]` instead of `&[&Transaction]`.
The `TransactionType` enum was redesigned with specific variants
(Funding, CooperativeClose, Sweep, etc.) replacing the old
`NonLightning` variant. Wallet-originated on-chain sends now use
`TransactionType::Sweep { channels: vec![] }`.
- `Event::SpendableOutputs` gained a `counterparty_node_id` field,
which is forwarded to `OutputSweeper::track_spendable_outputs` so
sweep transactions carry channel metadata.
- The `impl_writeable_tlv_based` legacy field syntax gained an
additional validation closure parameter.
- `negotiate_anchors_zero_fee_htlc_tx` now defaults to `true` upstream,
which changes force-close behavior (commitment transactions go through
BumpTransactionEvent rather than direct broadcast). The KVStore
persistence test is updated to use `test_legacy_channel_config()` to
match the upstream persister test pattern.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
I've assigned @tnull as a reviewer! |
Had planned to address this properly today, but then let's just get this PR landed ASAP to unblock you and then I'll open a follow-up. |
Pushed a change to at least not require |
No, please revert that, that makes it just more complicated. Let's get this landed and I'll fix later today. |
|
Not that it was the biggest addition, but reverted. |
3 participants
Bump rust-lightning from 817ab5e583 to b6c17c593a and bitcoin-payment-instructions to ea50a9d2a8.