Draft
Conversation
Introduce a local `TransactionType` enum mirroring LDK's `BroadcasterInterface::TransactionType` variants plus a local `OnchainSend` variant, and attach it to `PaymentKind::Onchain` as `tx_type: Option<TransactionType>`. The `TransactionBroadcaster` now intercepts and records the transaction type per-txid in an in-memory `HashMap` during broadcasting. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <[email protected]>
Extend `channel_full_cycle`, `onchain_send_receive`, and `run_splice_channel_test` to verify that the `tx_type` field on `PaymentKind::Onchain` matches the expected variant (`Funding`, `OnchainSend`, `Splice`, or `None` for externally-received payments). Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <[email protected]>
|
👋 Hi! This PR is now in draft status. |
tnull
commented
Feb 11, 2026
| /// The confirmation status of this payment. | ||
| status: ConfirmationStatus, | ||
| /// The type of the on-chain transaction, if known. | ||
| tx_type: Option<TransactionType>, |
Collaborator
Author
There was a problem hiding this comment.
Hmm, we should probably just default to Onchain if we don't know what it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #447.
Currently in draft as I'm not fully sure yet if we should just add
tx_typeas a field toPaymentKind::Onchain(current approach), or if each transaction type should be a separatePaymentKindto avoid too many types flying around.