Skip to content

Restrict CI build matrix to Linux+MSRV for PRs #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 1 commit into from
Feb 11, 2026
+8 −2
Merged

Restrict CI build matrix to Linux+MSRV for PRs #4410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ jobs:
strategy:
fail-fast: false
matrix:
platform: [ self-hosted, windows-latest, macos-latest ]
toolchain: [ stable, beta, 1.75.0 ] # 1.75.0 is the MSRV for all crates
platform: >-
Copy link
Collaborator

@TheBlueMatt TheBlueMatt Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just move the beta/macos/windows runs to a separate file? That way this stays readable and we can trivially swap it for nightly jobs if we still see backup.

Copy link
Contributor Author

@joostjager joostjager Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would require duplicating the steps I think? Or extracting the steps in a reusable workflow file perhaps.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we'd have to copy the steps, but they're basically all just file-download caching.

Copy link
Contributor Author

@joostjager joostjager Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the current change better. Minimal and non-duplicative. But can do the copy.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I find it hard to parse but not worth arguing about.

${{ github.event_name == 'push' && github.ref == 'refs/heads/main'
&& fromJSON('["self-hosted","windows-latest","macos-latest"]')
|| fromJSON('["self-hosted"]') }}
toolchain: >-
${{ github.event_name == 'push' && github.ref == 'refs/heads/main'
&& fromJSON('["stable","beta","1.75.0"]')
|| fromJSON('["1.75.0"]') }}
exclude:
- platform: windows-latest
toolchain: 1.75.0
Expand Down