Check that funder covers the fee spike buffer multiple after a splice#4433
Check that funder covers the fee spike buffer multiple after a splice#4433tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
tankyleo
force-pushed
the
2026-02-splice-assertions
branch
2 times, most recently
from
9035906 to
1959d52
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4433 +/- ##
==========================================
+ Coverage 85.94% 85.98% +0.04%
==========================================
Files 159 159
Lines 104644 104652 +8
Branches 104644 104652 +8
==========================================
+ Hits 89934 89989 +55
+ Misses 12204 12164 -40
+ Partials 2506 2499 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| 1 | ||
| }; | ||
|
|
||
| let feerate_per_kw = if !funding.get_channel_type().supports_anchors_zero_fee_htlc_tx() { |
There was a problem hiding this comment.
Shouldn't this be funding.get_channel_type() == ChannelTypeFeatures::only_static_remote_key?
There was a problem hiding this comment.
mentioned offline: only_static_remote_key would not match against only_static_remote_key + scid_privacy channels.
lightning/src/ln/splicing_tests.rs
Outdated
| // 4) Try again with the additional satoshi removed from the splice-out message, and check that it passes | ||
| // validation on the receiver's side. | ||
|
|
||
| let (preimage_1_to_0_d, node_1_real_splice_out) = { |
There was a problem hiding this comment.
Can we not DRY this up with the presage_0_to_1_d block below?
There was a problem hiding this comment.
Done below thank you, kept it as a function
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Notably, if a party splices funds into the channel, their new balance must be above the new reserve.
tankyleo
force-pushed
the
2026-02-splice-assertions
branch
2 times, most recently
from
35e63f7 to
c1b8f14
Compare
We do this for HTLCs, so we should also do this for splices. This applies to `only_static_remote_key` channels alone.
tankyleo
force-pushed
the
2026-02-splice-assertions
branch
from
c1b8f14 to
260dcc5
Compare
3 participants
and