Fix missing argument in splicing test#4441
Closed
vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Fix missing argument in splicing test#4441vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
The `RecipientOnionFields::secret_only` signature was updated to require a `total_mpp_amount_msat` parameter, but one call site in `do_abandon_splice_quiescent_action_on_shutdown` was not updated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
👋 Hi! Please choose at least one reviewer by assigning them on the right bar. |
Contributor
|
Let's fix this in #4388 to avoid more conflicts. |
Contributor
|
Fixed in 7e413a7 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4441 +/- ##
==========================================
- Coverage 85.89% 85.86% -0.04%
==========================================
Files 159 159
Lines 104402 104395 -7
Branches 104402 104395 -7
==========================================
- Hits 89681 89641 -40
- Misses 12216 12246 +30
- Partials 2505 2508 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecipientOnionFields::secret_onlywas updated to require atotal_mpp_amount_msatparameter, but one call site indo_abandon_splice_quiescent_action_on_shutdownwas not updated, breaking the test target compilation.Test plan
cargo check -p lightning --lib --testscompiles successfullyabandon_splice_quiescent_action_on_shutdowntest passes🤖 Generated with Claude Code