Skip to content

Comments

Fix missing argument in splicing test#4441

Closed
vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
vincenzopalazzo:fix/splicing-tests-secret-only-arg
Closed

Fix missing argument in splicing test#4441
vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
vincenzopalazzo:fix/splicing-tests-secret-only-arg

Conversation

@vincenzopalazzo
Copy link
Contributor

Summary

  • RecipientOnionFields::secret_only was updated to require a total_mpp_amount_msat parameter, but one call site in do_abandon_splice_quiescent_action_on_shutdown was not updated, breaking the test target compilation.

Test plan

  • cargo check -p lightning --lib --tests compiles successfully
  • abandon_splice_quiescent_action_on_shutdown test passes

🤖 Generated with Claude Code

The `RecipientOnionFields::secret_only` signature was updated to require
a `total_mpp_amount_msat` parameter, but one call site in
`do_abandon_splice_quiescent_action_on_shutdown` was not updated.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ldk-reviews-bot
Copy link

👋 Hi! Please choose at least one reviewer by assigning them on the right bar.
If no reviewers are assigned within 10 minutes, I'll automatically assign one.
Once the first reviewer has submitted a review, a second will be assigned if required.

@jkczyz
Copy link
Contributor

jkczyz commented Feb 24, 2026

Let's fix this in #4388 to avoid more conflicts.

@jkczyz
Copy link
Contributor

jkczyz commented Feb 24, 2026

Fixed in 7e413a7

@jkczyz jkczyz closed this Feb 24, 2026
@vincenzopalazzo vincenzopalazzo deleted the fix/splicing-tests-secret-only-arg branch February 24, 2026 19:09
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (df57978) to head (39f1c66).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4441      +/-   ##
==========================================
- Coverage   85.89%   85.86%   -0.04%     
==========================================
  Files         159      159              
  Lines      104402   104395       -7     
  Branches   104402   104395       -7     
==========================================
- Hits        89681    89641      -40     
- Misses      12216    12246      +30     
- Partials     2505     2508       +3     
Flag Coverage Δ
tests 85.86% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants