Skip to content

Pin hyper rustls #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 1 commit into from
Apr 14, 2026
+3 −0
Merged

Pin hyper rustls #4562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci/ci-tests-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ PIN_RELEASE_DEPS # pin the release dependencies in our main workspace
# Starting with version 1.2.0, the `idna_adapter` crate has an MSRV of rustc 1.81.0.
[ "$RUSTC_MINOR_VERSION" -lt 81 ] && cargo update -p idna_adapter --precise "1.1.0" --quiet

# Starting with version 0.27.8, the `hyper-rustls` crate has an MSRV of rustc 1.85.0.
[ "$RUSTC_MINOR_VERSION" -lt 85 ] && cargo update -p hyper-rustls --precise "0.27.7" --quiet
Copy link
Copy Markdown
Contributor

@tnull tnull Apr 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really not loving that we have to start pinning-back rustls-related / potentially security critical dependencies on MSRV.

Ubuntu 26.04 LTS release is just 9 days away (and 25.10 already supports up to rustc 1.88).

Can we rather just already bump our MSRV to 1.85? cc @TheBlueMatt

Copy link
Copy Markdown
Contributor Author

@joostjager joostjager Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's at least fix the problem with the pin for now.

Copy link
Copy Markdown
Collaborator

@TheBlueMatt TheBlueMatt Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real solution is bitcoindevkit/rust-esplora-client#180

Copy link
Copy Markdown
Collaborator

@TheBlueMatt TheBlueMatt Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that hyper-rustls is not rustls itself, its hyper's rustls wraper.

Copy link
Copy Markdown
Contributor

@tnull tnull Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that hyper-rustls is not rustls itself, its hyper's rustls wraper.

Ofc, which in turn however will/might restrict the set of compatbile rustls versions.


export RUST_BACKTRACE=1
Loading