fix(cli): guard against empty translations in PO loader#2000
Merged
cherkanovart merged 1 commit intomainfrom Feb 20, 2026
Merged
fix(cli): guard against empty translations in PO loader#2000cherkanovart merged 1 commit intomainfrom
cherkanovart merged 1 commit intomainfrom
Conversation
When a .po file section contains only obsolete entries or no translations, Object.keys() on undefined csEntries throws a TypeError. Add guards to skip sections with empty translations in the currentSections.find() callback, matching the existing pattern used in the outer map. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughA changeset file documents a patch-level fix for a crash in the PO loader. The actual fix adds validation guards to skip sections with no translations or missing translation entries during data push alignment, preventing the crash condition. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
ohmoses
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot convert undefined or null to objectcrash in PO loader'spushmethodcurrentSections.find()callback, matching the existing guard pattern in the outer.map()Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit