fix: hash emails before sending as PostHog distinct_id#2002
Open
cherkanovart wants to merge 1 commit intomainfrom
Open
fix: hash emails before sending as PostHog distinct_id#2002cherkanovart wants to merge 1 commit intomainfrom
cherkanovart wants to merge 1 commit intomainfrom
Conversation
Use SHA-256 hash of email instead of raw email for PostHog distinct_id across cli, compiler, and new-compiler packages to avoid sending PII. Closes ENG-378 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis change adds SHA-256 hashing of email addresses before sending them to PostHog as distinct_id identifiers. The crypto import and hashing logic are applied consistently across three observability utility files in separate packages (cli, compiler, new-compiler), with a corresponding changeset documenting the patch-level updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
ohmoses
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distinct_idacross cli, compiler, and new-compiler packagesChanged files
packages/cli/src/cli/utils/observability.tspackages/compiler/src/utils/observability.tspackages/new-compiler/src/utils/observability.tsTest plan
observability.spec.tstests passprettiertype issue in compiler is unrelated)Closes ENG-378
🤖 Generated with Claude Code
Summary by CodeRabbit