-
Notifications
You must be signed in to change notification settings - Fork 80
Align GHA workflows in the scope of report uploads #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds an opt-in workflow_dispatch input to control whether E2E test reports are uploaded, preventing automatic uploads on manually triggered runs unless explicitly requested.
Changes:
- Introduces a
test_report_uploadinput (defaultfalse) for manual workflow runs. - Updates conditional logic for uploading test reports to only run on push/PR events by default, or when explicitly enabled for
workflow_dispatch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/e2e-test.yml | Adds test_report_upload input and gates the report upload job for manual runs. |
| .github/workflows/e2e-test-pr.yml | Adds test_report_upload input and gates the “Upload test results” step for manual runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lgarber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing this!
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
📝 Description
GHA workflows upload test results to TOD on push, PR and manual (workflow_dispatch) runs. PR covers aligning integration test workflows to upload results automatically on push/PR and on demand for manual runs.
https://track.akamai.com/jira/browse/TPT-4190
✔️ How to Test
Manual run of the workflow should not upload test results to TOD by default.