Rename all shell scripts to *.sh + shellcheck -x success by tlaurion · Pull Request #2050 · linuxboot/heads

tlaurion · 2026-02-14T00:43:34Z

No description provided.

Copilot

Pull request overview

This PR renames shell scripts to include .sh extensions and adds shellcheck compliance improvements. It updates script references across config files and adds shellcheck directives to scripts.

Changes:

Renamed shell scripts by adding .sh extension
Updated CONFIG_BOOTSCRIPT paths in board configuration files
Added shellcheck source directives and disabled warnings where appropriate
Improved shell script compliance with shellcheck recommendations

Reviewed changes

Copilot reviewed 105 out of 158 changed files in this pull request and generated 13 comments.

File	Description
Config files (boards/*)	Updated CONFIG_BOOTSCRIPT paths to use .sh extensions
Shell scripts (initrd/bin/*)	Renamed scripts, added shellcheck directives, improved compliance
Config files (unmaintained_boards/*)	Updated CONFIG_BOOTSCRIPT paths, some with inconsistent leading slash
initrd/init	Updated script calls and added shellcheck compliance fixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-14T00:51:51Z

unmaintained_boards/UNTESTED_tioga/UNTESTED_tioga.config

 CONFIG_LINUX_BCM=y

-export CONFIG_BOOTSCRIPT=/bin/generic-init
+export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.

Copilot · 2026-02-14T00:51:51Z

unmaintained_boards/UNTESTED_s2600wf/UNTESTED_s2600wf.config


 export CONFIG_TPM=n
-export CONFIG_BOOTSCRIPT=/bin/generic-init
+export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.

Copilot · 2026-02-14T00:51:51Z

unmaintained_boards/UNTESTED_r630/UNTESTED_r630.config

 CONFIG_LINUX_E1000E=y

-export CONFIG_BOOTSCRIPT=/bin/generic-init
+export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.

Copilot · 2026-02-14T00:51:52Z

...INED_kgpe-d16_workstation-usb_keyboard/UNMAINTAINED_kgpe-d16_workstation-usb_keyboard.config

 export CONFIG_QUIET_MODE=y
-export CONFIG_BOOTSCRIPT=/bin/gui-init
-#export CONFIG_BOOTSCRIPT_NETWORK=/bin/network-init-recovery
+#export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT commented line. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" for consistency.

Copilot · 2026-02-14T00:51:52Z

...ed_boards/UNMAINTAINED_kgpe-d16_server-whiptail/UNMAINTAINED_kgpe-d16_server-whiptail.config

-#export CONFIG_BOOTSCRIPT=/bin/generic-init
-export CONFIG_BOOTSCRIPT=/bin/gui-init
-#export CONFIG_BOOTSCRIPT_NETWORK=/bin/network-init-recovery
+#export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT commented line. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" for consistency.

Copilot · 2026-02-14T00:51:53Z

unmaintained_boards/UNTESTED_winterfell/UNTESTED_winterfell.config

 CONFIG_LINUX_NVME=y

-export CONFIG_BOOTSCRIPT=/bin/generic-init
+export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.

Copilot · 2026-02-14T00:51:53Z

unmaintained_boards/UNTESTED_leopard/UNTESTED_leopard.config

 #CONFIG_LINUX_NVME=y

-export CONFIG_BOOTSCRIPT=/bin/generic-init
+export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" to match the pattern used in other config files.

Copilot · 2026-02-14T00:51:53Z

unmaintained_boards/UNMAINTAINED_kgpe-d16_workstation/UNMAINTAINED_kgpe-d16_workstation.config

 export CONFIG_QUIET_MODE=y
-export CONFIG_BOOTSCRIPT=/bin/gui-init
-#export CONFIG_BOOTSCRIPT_NETWORK=/bin/network-init-recovery
+#export CONFIG_BOOTSCRIPT="bin/generic-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT commented line. This line has "bin/generic-init.sh" but should be "/bin/generic-init.sh" for consistency with the pattern used in other config files.

Copilot · 2026-02-14T00:51:53Z

boards/EOL_t420-hotp-maximized/EOL_t420-hotp-maximized.config

 #Enable quiet mode: technical information logged under /tmp/debug.log
 export CONFIG_QUIET_MODE=y
-export CONFIG_BOOTSCRIPT=/bin/gui-init
+export CONFIG_BOOTSCRIPT="bin/gui-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/gui-init.sh" but should be "/bin/gui-init.sh" to match the pattern used in other config files.

Suggested change

export CONFIG_BOOTSCRIPT="bin/gui-init.sh"

export CONFIG_BOOTSCRIPT="/bin/gui-init.sh"

Copilot · 2026-02-14T00:51:54Z

boards/EOL_optiplex-7010_9010_TXT-maximized/EOL_optiplex-7010_9010_TXT-maximized.config

 #Enable quiet mode: technical information logged under /tmp/debug.log
 export CONFIG_QUIET_MODE=y
-export CONFIG_BOOTSCRIPT=/bin/gui-init
+export CONFIG_BOOTSCRIPT="bin/gui-init.sh"


Missing leading slash in CONFIG_BOOTSCRIPT path. This line has "bin/gui-init.sh" but should be "/bin/gui-init.sh" to match the pattern used in other config files.

Suggested change

export CONFIG_BOOTSCRIPT="bin/gui-init.sh"

export CONFIG_BOOTSCRIPT="/bin/gui-init.sh"

tlaurion · 2026-02-16T18:22:49Z

Unfortunately something broke with tpm sealing unsealing totp and not ready for full test/review.

…s; TPM primary/unseal hardening - Implement tpm2_verify_primary() and 'verify-primary' subcommand in `initrd/bin/tpmr.sh`. - Make `tpm2_unseal()` non‑fatal to callers; return distinct error codes on failure. - Invalidate cached TPM Owner Password when primary handle is missing or primhdl hash mismatches. - Add verify‑primary pre‑checks where appropriate: `unseal-totp.sh`, `unseal-hotp.sh`, `kexec-unseal-key.sh`, and GUI (`update_totp()`). - Fix `gui-init.sh` parsing/shellcheck issues and silence relevant shellcheck warnings. Why: ensure 'verify before unseal' to avoid silent unseal on primary/primhdl changes, present clear tamper UI and allow caller remediation. Validation: shellcheck and `bash -n` pass for edited scripts; runtime log re‑inspection shows `tpm2_verify_primary` runs before unseal. TODO: oem-factory-reset fails to unseal while tpm reset + seal totp + seal hotp succeeds. Fix Signed-off-by: Thierry Laurion <insurgo@riseup.net>

Signed-off-by: Thierry Laurion <insurgo@riseup.net>

Copilot AI review requested due to automatic review settings February 14, 2026 00:43

Copilot started reviewing on behalf of tlaurion February 14, 2026 00:44 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

tlaurion force-pushed the shellcheck_fixes branch 2 times, most recently from cdfe716 to b1aaf47 Compare February 16, 2026 14:35

tlaurion marked this pull request as draft February 16, 2026 18:22

tlaurion added 2 commits February 18, 2026 15:15

wip fixup oem-factory-reset.sh

b4e3add

Signed-off-by: Thierry Laurion <insurgo@riseup.net>

tlaurion force-pushed the shellcheck_fixes branch from b1aaf47 to b4e3add Compare February 23, 2026 05:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename all shell scripts to *.sh + shellcheck -x success#2050

Rename all shell scripts to *.sh + shellcheck -x success#2050
tlaurion wants to merge 2 commits intolinuxboot:masterfrom
tlaurion:shellcheck_fixes

tlaurion commented Feb 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

tlaurion commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	export CONFIG_BOOTSCRIPT="bin/gui-init.sh"
	export CONFIG_BOOTSCRIPT="/bin/gui-init.sh"

Uh oh!

Conversation

tlaurion commented Feb 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

tlaurion commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants