Skip to content

tpmr: added helper and enhanced reset routines with clearcontrol and error checks#2052

Merged
tlaurion merged 1 commit intolinuxboot:masterfrom
tlaurion:tpmr_add_clearcontrol
Feb 23, 2026
Merged

tpmr: added helper and enhanced reset routines with clearcontrol and error checks#2052
tlaurion merged 1 commit intolinuxboot:masterfrom
tlaurion:tpmr_add_clearcontrol

Conversation

@tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Feb 21, 2026

Refactor tpm1/tpm2 reset functions for better error handling, adding clear control around tpm reset attemtping to fix reported user error under matrix (#2051)

Fixes #2051

tested over kvm with last commits of master

  • qemu-coreboot-fbwhiptail-tpm1
  • qemu-coreboot-fbwhiptail-tpm2

Real hardware tests to make sure no regressions exist:

  • novacustom-nv4x_adl (tpm2)
  • x230-hotp-maximized (tpm1.2)

Copilot AI review requested due to automatic review settings February 21, 2026 01:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tlaurion tlaurion force-pushed the tpmr_add_clearcontrol branch 2 times, most recently from 14283df to dc4d1de Compare February 21, 2026 01:32
@tlaurion
Copy link
Collaborator Author

Might also help #2047

@tlaurion
Copy link
Collaborator Author

nitpick, fix double comment + amend before merge

…error checks

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
@tlaurion tlaurion force-pushed the tpmr_add_clearcontrol branch from dc4d1de to 9aed7ca Compare February 23, 2026 00:08
@tlaurion
Copy link
Collaborator Author

User confirms it resolves his issue on t480 on matrix

@tlaurion tlaurion merged commit 8644650 into linuxboot:master Feb 23, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heads cannot take for granted that TPM is in a clean/cleared state when doing TPM Reset

2 participants