-
Notifications
You must be signed in to change notification settings - Fork 122
Adding feature_flags field to sip requests #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding feature_flags field to sip requests #1382
Conversation
🦋 Changeset detectedLatest commit: b5fa41b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| livekit.SIPMediaEncryption media_encryption = 22; | ||
|
|
||
| // NEXT ID: 23 | ||
| map<string, string> feature_flags = 23; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be on GetTrunkAuth, otherwise it might be too late for some features. Or we could put it in both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm.. I can add it there as well, but the code isn't ready for that quite yet. I'll do that now though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it more @alexlivekit , something like feature flags is usually tied to Auth/Accounts. So it makes sense to add it there. The other thing to note is we might use feature flags to decide things like when to send back the 100 trying, 180 which would happen before EvaluateSipDispatchRules.
No description provided.