update tokio-tungstenite and tokio-rustls#754
Conversation
|
tokio-rustls 0.24 has been dragging in an old rustls 0.21.12 in addition to the rustls 0.23 used by the rest of the dependency tree 🙈 |
0245805 to
85b27d5
Compare
|
Currently, E2E tests in CI run with a local SFU in dev mode without TLS. In order to make sure this doesn't break anything, we need to verify E2E tests pass with a LiveKit Cloud SFU and the LIVEKIT_URL=wss://my-project.livekit.cloud \
LIVEKIT_API_KEY=xxx \
LIVEKIT_API_SECRET=xxx \
cargo test --features rustls-tls-native-roots,__lk-e2e-test -- --nocaptureI'm going to look into what the issue is here, but currently, I get the following runtime error when running E2E tests with TLS: |
|
I think this is the issue: |
85b27d5 to
b20c668
Compare
I think so. livekit-api's rustls-tls-native-roots feature activates reqwest's rustls-tls-native-roots feature, which activates reqwest's __rustls_ring feature, which activates the ring feature of rustls. I think this was not causing a problem before because of the separate old version of rustls being used by livekit-api. |
|
@ladvoc any thoughts how to resolve this? |
|
Let me take a closer look and get back to you on that. |
b20c668 to
ff6041e
Compare
split off from #609