This repository was archived by the owner on Dec 2, 2025. It is now read-only.
Remove double byte copy in lz4 unsafe utils#182
Open
Tim-Brooks wants to merge 1 commit intolz4:masterfrom
Open
Remove double byte copy in lz4 unsafe utils#182Tim-Brooks wants to merge 1 commit intolz4:masterfrom
Tim-Brooks wants to merge 1 commit intolz4:masterfrom
Conversation
Currently in LZ4UnsafeUtils#safeIncrementalCopy every byte is copied twice. First the byte is copied using the normal byte array syntax and then the byte is copied using unsafe. Only one of these copies is needed. This commit deletes the non-unsafe copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in LZ4UnsafeUtils#safeIncrementalCopy every byte is copied
twice. First the byte is copied using the normal byte array syntax and
then the byte is copied using unsafe. Only one of these copies is
needed. This commit deletes the non-unsafe copy.