Use the pivot table directly for taxa#1269
Merged
Conversation
Contributor
|
Hi @jonbrenas, really nice fix. Deriving taxa from the pivot table makes the data flow much more consistent and resolves the mismatch cleanly. One small non-blocking thought: if we capture taxa from Also, would it be worth adding a small regression test for this scenario (samples with no location data or colony-only datasets)? Happy to put one together if that would help. |
Collaborator
Author
|
I think you are right. I don't think the tests are needed, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1268