This repository was archived by the owner on Apr 24, 2024. It is now read-only.
assert documentation exists when mapboxjs version is bumped#1309
Merged
katydecorah merged 1 commit intopublisher-productionfrom Oct 18, 2019
Merged
assert documentation exists when mapboxjs version is bumped#1309katydecorah merged 1 commit intopublisher-productionfrom
katydecorah merged 1 commit intopublisher-productionfrom
Conversation
|
@katydecorah When will this test run? I don't think tests are run in Travis. Running tests locally is also hard because of the required dependencies (i.e. phantomjs). I think tests could fail and nobody would notice. |
Contributor
|
@whyvez the test was run on this PR https://travis-ci.org/mapbox/mapbox.js/builds/599273048#L520. I think the idea here is that docs should be created first, then version numbers bumped. |
Contributor
Author
|
The automated script in #1308 is awesome. I would still like to include this test as added assurance that documentation exists when the version is bumped in the publisher config to prevent broken pages - this is critical to documentation's operational excellence. |
danswick
approved these changes
Oct 17, 2019
Contributor
danswick
left a comment
There was a problem hiding this comment.
This test looks great, @katydecorah!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
mapboxjsis updated in _config.publisher-production.yml the documentation for that version must exist, otherwise, the production site will redirect to the 404 page. This is because the Mapbox.js landing page redirects to the latest version of the documentation.This PR adds a test to verify that the documentation folder exists for the current
mapboxjsversion in _config.publisher-production.yml. If the folder does not exist, the tests will fail.cc @whyvez @alulsh