Open
Conversation
t20100
force-pushed
the
probe-matlab-at-runtime
branch
from
7a06dda to
75f9416
Compare
t20100
commented
Aug 21, 2025
| """ | ||
| Returns True if matlab folders should be configured at build time | ||
| """ | ||
| return os.environ.get('MATLAB_ENGINE_CONFIGURE_ROOT', 'true').lower() in ('true', '1') |
Author
There was a problem hiding this comment.
Use env.var. to pass options, it could be replaced with extra build arguments
|
|
||
|
|
||
| @functools.cache | ||
| def get_path_info() -> MatlabPathInfo: |
Author
There was a problem hiding this comment.
Read _arch.txt and use which matlab as fallback.
This could be more involved and use the whole _MatlabFinder logic.
| if _envs[_arch] in os.environ: | ||
| _env = os.environ[_envs[_arch]] | ||
| os.environ[_envs[_arch]] = _bin_dir + os.pathsep + os.environ[_envs[_arch]] | ||
| _path_info = _utils.get_path_info() |
Author
There was a problem hiding this comment.
Reuse path info rather than re-reading the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a minimal implementation of probing matlab installation paths at runtime from the commands in
$PATHrather than at build time (Related to #45):_arch.txtfile if it is in the packageshutil.which('matlab')as a fallbacksetup.pyto build without_arch.txt, e.g. to generate a wheel.I tested it on Linux and it should work on macos.
A more involved option would be to move the code finding matlab from
setup.pyinto matlab-engine and call it at runtime rather than storing the info in_arch.txt+ a fallback usingshutil.which('matlab')