Implement guided generation for GeminiLanguageModel#115
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements guided generation support (using @Generable and @Guide macros) for GeminiLanguageModel, addressing issue #27. Previously, the model only supported generating String content and would throw a fatal error when attempting to generate structured types. This change enables GeminiLanguageModel to generate structured data using JSON schemas, bringing it to feature parity with other language models like OpenAI and Anthropic.
Changes:
- Removed the String-only restriction and added full support for generating structured
Generabletypes - Implemented automatic JSON schema generation and response parsing for non-String types
- Added comprehensive test suite following established testing patterns for structured output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Sources/AnyLanguageModel/Models/GeminiLanguageModel.swift | Core implementation: removed String-only guards, added schema conversion, JSON response handling for both streaming and non-streaming generation, and helper functions for empty content handling |
| Tests/AnyLanguageModelTests/GeminiLanguageModelTests.swift | Added structured output test suite with tests for basic generation, optional fields, different types, and streaming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #27