Skip to content

Added dimension setup & posted entries for fixed assets #29390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tuan-nguyen-fenwick wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Added dimension setup & posted entries for fixed assets #29390

tuan-nguyen-fenwick wants to merge 15 commits into from
+275 −34

Conversation

@tuan-nguyen-fenwick
Copy link
Contributor

@tuan-nguyen-fenwick tuan-nguyen-fenwick commented Nov 7, 2025 •
edited by github-actions bot
Loading

Summary

Added dimension setup and posted entries for Fixed Assets in Demo Data Tool.

Work Item(s)

Fixes #29388
Fixes AB#597245

Tuan Nguyen added 5 commits November 5, 2025 16:57
Added dimension setup to fixed assets
2879ddb
Added InsertFixedAsset function that takes FA Posting Group parameter
e4c3ea2
Added FA posting group to fixed asset dataset
122e0f8
Added codeunits to generate FA journal lines & posted entries
b183a44
Merged PR 38641: Dimension setup & posted entries for Fixed Assets
63d9a69 
Excel report outputs showing meaningful data:
- [Fixed Asset Projected Value (Excel).xlsx](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/Fixed%20Asset%20Projected%20Value%20%28Excel%29.xlsx)
- [Fixed Asset Details (Excel).xlsx](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/Fixed%20Asset%20Details%20%28Excel%29.xlsx)
- [Fixed Asset Analysis (Excel).xlsx](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/Fixed%20Asset%20Analysis%20%28Excel%29.xlsx)

FA Ledger Entries:

![image.png](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/image.png)

Published to: http://bcdev2.fenwicksoftware.com.au:10320/BC/?company=Demo21-FA

Related work items: microsoft#28277
@tuan-nguyen-fenwick tuan-nguyen-fenwick requested a review from a team as a code owner November 7, 2025 04:32
@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Nov 10, 2025
@AndersLarsenMicrosoft AndersLarsenMicrosoft self-assigned this Nov 24, 2025
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Dec 12, 2025
PredragMaricic
PredragMaricic previously approved these changes Dec 14, 2025
View reviewed changes
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Dec 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Dec 19, 2025

Another PR where the local DBs don't build any longer. This time with the following:

[2025-12-19 10:52:02] Invoke-jobNAVCodeunit: Document No. ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and
--------------------- Amount are correct for each line.  CorrelationId:  f0751f7f-4d76-488e-8cca-e99f776d2632. Status: 400 (Document No.
--------------------- ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and Amount are
--------------------- correct for each line.) ErrorCode: Application_DialogException  Content:
--------------------- {"error":{"code":"Application_DialogException","message":"Document No. ASSET-ACQ is out of balance by 321.500. Please
--------------------- check that Posting Date, Document Type, Document No. and Amount are correct for each line.  CorrelationId: 
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632."}}  Headers: Server: Microsoft-HTTPAPI/2.0 request-id:
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAACyeJ/gbKiokAAAAAA= Date: Fri, 19
--------------------- Dec 2025 09:51:46 GMT Content-Type: application/json Content-Length: 266

We need to understand what's happening. But that'll be a job for 2026 😉

@tuan-nguyen-fenwick
Copy link
Contributor Author

tuan-nguyen-fenwick commented Jan 2, 2026

Another PR where the local DBs don't build any longer. This time with the following:

[2025-12-19 10:52:02] Invoke-jobNAVCodeunit: Document No. ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and
--------------------- Amount are correct for each line.  CorrelationId:  f0751f7f-4d76-488e-8cca-e99f776d2632. Status: 400 (Document No.
--------------------- ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and Amount are
--------------------- correct for each line.) ErrorCode: Application_DialogException  Content:
--------------------- {"error":{"code":"Application_DialogException","message":"Document No. ASSET-ACQ is out of balance by 321.500. Please
--------------------- check that Posting Date, Document Type, Document No. and Amount are correct for each line.  CorrelationId: 
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632."}}  Headers: Server: Microsoft-HTTPAPI/2.0 request-id:
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAACyeJ/gbKiokAAAAAA= Date: Fri, 19
--------------------- Dec 2025 09:51:46 GMT Content-Type: application/json Content-Length: 266

We need to understand what's happening. But that'll be a job for 2026 😉

Hi @JesperSchulz, Happy New Year!

Can you share which region(s) throwed this error please?

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jan 6, 2026 •
edited
Loading

Another PR where the local DBs don't build any longer. This time with the following:

[2025-12-19 10:52:02] Invoke-jobNAVCodeunit: Document No. ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and
--------------------- Amount are correct for each line.  CorrelationId:  f0751f7f-4d76-488e-8cca-e99f776d2632. Status: 400 (Document No.
--------------------- ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and Amount are
--------------------- correct for each line.) ErrorCode: Application_DialogException  Content:
--------------------- {"error":{"code":"Application_DialogException","message":"Document No. ASSET-ACQ is out of balance by 321.500. Please
--------------------- check that Posting Date, Document Type, Document No. and Amount are correct for each line.  CorrelationId: 
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632."}}  Headers: Server: Microsoft-HTTPAPI/2.0 request-id:
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAACyeJ/gbKiokAAAAAA= Date: Fri, 19
--------------------- Dec 2025 09:51:46 GMT Content-Type: application/json Content-Length: 266

We need to understand what's happening. But that'll be a job for 2026 😉

Hi @JesperSchulz, Happy New Year!

Can you share which region(s) throwed this error please?

BuildDatabase_CZ, BuildDatabase_DK and BuildDatabase_NL.

And happy new year 🥳

@tuan-nguyen-fenwick
Copy link
Contributor Author

tuan-nguyen-fenwick commented Jan 8, 2026 •
edited
Loading

@JesperSchulz

I have resolved build errors in CZ, DK and NL environments. Turns out there is a unique G/L account for the cash account in CZ, DK and NL which caused FA journal lines to be out of balance. I had to retrieve the corresponding account in these localised apps.

I also made adjustments to resolve ID conflicts with new objects after merging latest changes from main.

The screenshot below is from BC container platform: CZ 28.0.44120.0

image

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jan 8, 2026

Let me try again!

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jan 8, 2026

NL build failed:
CreateFADepreciationBookNL.Codeunit.al(37,29): error AL0185: Codeunit 'Create NL GL Accounts' is missing

@tuan-nguyen-fenwick
Copy link
Contributor Author

tuan-nguyen-fenwick commented Jan 8, 2026

NL build failed: CreateFADepreciationBookNL.Codeunit.al(37,29): error AL0185: Codeunit 'Create NL GL Accounts' is missing

@JesperSchulz Thanks, it should be fixed now. I corrected the namespace usage.

@tuan-nguyen-fenwick
Copy link
Contributor Author

tuan-nguyen-fenwick commented Jan 13, 2026

@JesperSchulz Please let me know if there’s anything else needed to wrap up this PR. Thanks!

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jan 14, 2026

@JesperSchulz Please let me know if there’s anything else needed to wrap up this PR. Thanks!

I'll try running it again with the latest chages.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jan 15, 2026

DK now fails with the following:

�[31;1mInvoke-jobNAVCodeunit: �[31;1mFeltet Bal. Account No. i tabellen Gen. Journal Line indeholder en værdi (18000), som ikke blev fundet i den relaterede�[0m
�[31;1m�[31;1mtabel (G/L Account).  CorrelationId:  5107be2e-f1b5-40bc-92bf-3d4bb0683021. Status: 400 (Feltet Bal. Account No. i�[0m
�[31;1m�[31;1mtabellen Gen. Journal Line indeholder en værdi (18000), som ikke blev fundet i den relaterede tabel (G/L Account).)�[0m
�[31;1m�[31;1mErrorCode: Internal_InvalidTableRelation  Content: {"error":{"code":"Internal_InvalidTableRelation","message":"Feltet�[0m
�[31;1m�[31;1mBal. Account No. i tabellen Gen. Journal Line indeholder en v\u00e6rdi (18000), som ikke blev fundet i den relaterede�[0m
�[31;1m�[31;1mtabel (G/L Account).  CorrelationId:  5107be2e-f1b5-40bc-92bf-3d4bb0683021."}}  Headers: Server: Microsoft-HTTPAPI/2.0�[0m
�[31;1m�[31;1mrequest-id: 5107be2e-f1b5-40bc-92bf-3d4bb0683021 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAADqhxSiOHk3ZQAAAAA=�[0m
�[31;1m�[31;1mDate: Wed, 14 Jan 2026 18:51:58 GMT Content-Type: application/json Content-Length: 263�[0m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersLarsenMicrosoft AndersLarsenMicrosoft AndersLarsenMicrosoft approved these changes

@PredragMaricic PredragMaricic PredragMaricic left review comments

@haoranpb haoranpb Awaiting requested review from haoranpb haoranpb is a code owner automatically assigned from microsoft/dynamics-365-business-central

@attilatoury attilatoury Awaiting requested review from attilatoury

Assignees

@AndersLarsenMicrosoft AndersLarsenMicrosoft

Labels

Finance GitHub request for Finance area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BC Idea]: Dimensions & posted entries for fixed assets demo data

4 participants

@tuan-nguyen-fenwick @JesperSchulz @AndersLarsenMicrosoft @PredragMaricic