Skip to content

Upgrade Error Prone to 2.46.0 with Java 8 target compatibility #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upgrade Error Prone to 2.46.0 with Java 8 target compatibility #4605

Copilot wants to merge 5 commits into from
+11 −6

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026 •
edited
Loading

Error Prone 2.46.0 introduces AddNullMarkedToClass check which requires JSpecify's @NullMarked annotation. This annotation references ElementType.MODULE (Java 9+) causing compilation failures when targeting Java 8 with --release 8.

Changes

  • Disabled AddNullMarkedToClass in Error Prone configuration
  • Upgraded errorProneVersion from 2.44.0 to 2.46.0
// buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts
disable("AddNullMarkedToClass")

// dependencyManagement/build.gradle.kts
val errorProneVersion = "2.46.0"

Follows existing pattern - AddNullMarkedToPackageInfo already disabled for same reason.

Original prompt

Fix the failing checks in PR #4586

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix the failing checks in pull request 4586 Disable AddNullMarkedToClass check for Java 8 compatibility Jan 28, 2026
Copilot AI requested a review from xiang17 January 28, 2026 20:09
Copilot AI changed the title Disable AddNullMarkedToClass check for Java 8 compatibility Disable AddNullMarkedToClass check for Java 8 target compatibility Feb 4, 2026
@xiang17
Upgrade Error Prone version from 2.44.0 to 2.46.0
18ac515 
Co-authored-by: xiang17 <9310587+xiang17@users.noreply.github.com>
Copilot AI changed the title Disable AddNullMarkedToClass check for Java 8 target compatibility Upgrade Error Prone to 2.46.0 with Java 8 target compatibility Feb 5, 2026
@xiang17 xiang17 marked this pull request as ready for review February 5, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@xiang17 xiang17 Awaiting requested review from xiang17 xiang17 is a code owner

@harsimar harsimar Awaiting requested review from harsimar harsimar is a code owner

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti jeanbisutti is a code owner

@johnoliver johnoliver Awaiting requested review from johnoliver johnoliver is a code owner

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees

@xiang17 xiang17

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trask @xiang17