Enhanced Subscription & Billing demo data for Power BI reporting #6143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
December 12, 2025 16:40
New updates to Sub & Billing Demo Data app: - Updated last used no series. - Added subscriptions - Added customer and vendor subscription contracts - Created analysis entries for PowerBI reporting. http://bcdev2.fenwicksoftware.com.au:10470/BC/?company=DemoSB3 Related work items: #29613
github-actions
bot
added
AL: Apps (W1)
|
Issue #6142 is not valid. Please make sure you link an issue that exists, is open and is approved. |
attilatoury
reviewed
Jan 14, 2026
| end; | ||
| end; | ||
|
|
||
| local procedure CreateContractAnalysisEntry(ServiceCommitment: Record "Subscription Line"; AnalysisDate: Date) |
There was a problem hiding this comment.
Suggested change
| local procedure CreateContractAnalysisEntry(ServiceCommitment: Record "Subscription Line"; AnalysisDate: Date) | |
| local procedure CreateContractAnalysisEntry(SubscriptionLine: Record "Subscription Line"; AnalysisDate: Date) |
I am not familiar with this record so maybe your name makes more sense, but generally we name the record variables exactly like their source table.
|
|
||
| ServiceObject.Validate("End-User Customer No.", CustomerNo); | ||
| ServiceObject.Validate("Provision Start Date", ProvisionStartDate); | ||
| if ProvisionEndDate <> 0D then |
There was a problem hiding this comment.
Should we check that StartDate < EndDate? Unless it is already done in the table field's OnValidate trigger.
| VendorContract.CreateVendorContractLineFromServiceCommitment(ServiceCommitment); | ||
| end; | ||
|
|
||
| procedure AddVendorContractLine(ContractNo: Code[20]; ObjectNo: Code[20]) |
There was a problem hiding this comment.
Call this procedure at the end of the procedure above (InsertVendorContractLine) if it is intended to do the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Subscription & Billing Demo Data
Work Item(s)
Fixes #6142
Fixes AB#614285