-
Notifications
You must be signed in to change notification settings - Fork 829
[SM6.10] Codegen for attributed LinAlg Matrix types #8132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hekota
wants to merge
23
commits into
microsoft:main
Choose a base branch
from
hekota:linalg-attr-matrix-types-codegen2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a built-in type `__builtin_LinAlg_Matrix` that will be used in LinAlg Matrix implementation.
…iler into matrix-builtin-handle-type
…iler into matrix-builtin-handle-type
…://github.com/microsoft/DirectXShaderCompiler into linalg-matrix-attributes-and-types
… of https://github.com/microsoft/DirectXShaderCompiler into linalg-attr-matrix-types-codegen2
tex3d
reviewed
Feb 5, 2026
Contributor
tex3d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main point: "TargetTypes" sounds more general than this appears to be. Should we make the metadata more general with a class identifier, or change the name to be more specific?
V-FEXrt
previously approved these changes
Feb 9, 2026
tools/clang/test/CodeGenDXIL/hlsl/linalg/linalg-matrix-type.hlsl
Outdated
Show resolved
Hide resolved
tex3d
previously approved these changes
Feb 11, 2026
…iler into linalg-attr-matrix-types-codegen2
Contributor
You can test this locally with the following command:darker --check --diff -r 57a71b0cc5837c5989038734b12076655285918d..f666744dd794a60982e6ef8a47be1031e8a2c830 utils/hct/hctdb.pyView the diff from darker here.--- hctdb.py 2026-02-11 21:19:12.000000 +0000
+++ hctdb.py 2026-02-12 06:46:13.438004 +0000
@@ -1181,11 +1181,11 @@
i.shader_stages = (
"compute",
"mesh",
"amplification",
)
-
+
for i in insts("DebugBreak", "IsDebuggerPresent"):
i.category = "Debugging"
i.shader_model = experimental_sm
def populate_llvm_instructions(self):
|
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds codegen for Attributed LinAlgMatrix types. Each type is translated into its corresponding DXIL type
%dx.types.LinAlgMatrix<mangling>where<mangling>encodes the matrix attributes.For example this type:
Will be traslated to
%dx.types.LinAlgMatrixC4M4N5U1S2.Also adds
!dx.targetTypesmetadata node that lists all LinAlgMatrix types that were ever used in the module. For the example above that would be:Later after optimizations these metadata nodes should be pruned to contain only the types actually used in the module (task #8133).
Fixes #8123
Fixes #8127