update project to use dotnet 8 9 10#953
update project to use dotnet 8 9 10#953AdaskoTheBeAsT wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Pull request overview
This pull request attempts to upgrade the .NET SDK and project dependencies to target .NET 10.0, along with .NET 9.0 and 8.0. However, this PR has critical issues: .NET 10.0 has not been released yet as of January 2025. The PR references non-existent framework versions and package versions throughout the codebase, which will cause build failures. Additionally, there is a code bug in the DefaultCheckpointNamingScheme.cs file that will cause runtime errors.
Key Changes (Problematic)
- Targets non-existent .NET 10.0 SDK across all C# projects (should use .NET 9.0 as the latest)
- Updates package dependencies to non-existent version numbers (e.g., Microsoft.NET.Test.Sdk 18.0.1, NUnit3TestAdapter 6.0.0, Microsoft.Extensions.Logging 10.0.0)
- Introduces a code bug in DefaultCheckpointNamingScheme.cs where array Reverse() is incorrectly used
- Updates CI pipelines to install non-existent .NET SDK 10.0.x
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cs/FASTER.sln | References non-existent Visual Studio Version 18; adds .editorconfig to solution items |
| cs/.editorconfig | New file defining formatting rules for .csproj and .props files (valid addition) |
| cs/src/core/FASTER.core.csproj | Updates to non-existent .NET 10.0 and uses non-existent package versions (10.0.0) |
| cs/src/core/Utilities/FasterException.cs | Adds preprocessor directive for serialization constructor (valid change for .NET compatibility) |
| cs/src/core/Index/CheckpointManagement/DefaultCheckpointNamingScheme.cs | Introduces bug in #else block where array Reverse() is called incorrectly |
| cs/src/devices/AzureStorageDevice/FASTER.devices.AzureStorageDevice.csproj | Updates to non-existent .NET 10.0; updates Azure.Storage.Blobs to valid 12.26.0 |
| cs/test/FASTER.test.csproj | Updates to non-existent .NET 10.0 and non-existent test package versions |
| cs/stress/FASTER.stress.csproj | Updates to non-existent .NET 10.0 |
| cs/benchmark/FASTER.benchmark.csproj | Updates to non-existent .NET 10.0 |
| cs/performance/BenchmarkDotNet/BenchmarkDotNetTests.csproj | Updates to non-existent .NET 10.0; updates BenchmarkDotNet to valid 0.15.8 |
| cs/playground/* (7 projects) | All update to non-existent .NET 10.0; some update packages to valid versions |
| cs/samples/* (11 projects) | All update to non-existent .NET 10.0 |
| azure-pipelines.yml | Attempts to install non-existent .NET SDK 10.0.x; updates Node.js to valid 24.x |
| azure-pipelines-full.yml | Attempts to install non-existent .NET SDK 10.0.x; updates Node.js to valid 24.x |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hmmm I am not sure if there are still persons there who cares about that project :/ |
This pull request upgrades the .NET SDK and project dependencies across the codebase to target .NET 10.0, updates related package versions, and modernizes CI pipeline configurations. Additionally, it introduces a new
.editorconfigfor consistent code formatting and updates the Visual Studio solution file for compatibility with the latest version..NET SDK and Project Upgrades:
Updated all
.csprojfiles incs/benchmark,cs/performance,cs/playground, andcs/samplesdirectories to target.NET 10.0instead of.NET 7.0, ensuring the codebase uses the latest .NET features and performance improvements. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Updated package dependencies in several projects, such as upgrading
BenchmarkDotNetandBenchmarkDotNet.Diagnostics.Windowsto0.15.8,MessagePackto3.1.4, andxunit.assertto2.9.3for compatibility with .NET 10.0. [1] [2] [3]CI/CD Pipeline Modernization:
azure-pipelines.ymlandazure-pipelines-full.ymlto use .NET SDK versions 8.0, 9.0, and 10.0 (instead of 6.0 and 7.0), and updated the Node.js version to24.xfor build/test steps. [1] [2] [3] [4]Development Environment and Tooling:
Added a
.editorconfigfile for consistent indentation and formatting of.csprojand.propsfiles, and included it in the Visual Studio solution items. [1] [2]Updated the Visual Studio solution file (
FASTER.sln) to be compatible with Visual Studio 2022 (v18), reflecting the latest development environment.