Skip to content

fix: optimize parsing V3.1 documents by reducing GetLocation method allocation on hot path(#2748) #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 1 commit into from
Feb 25, 2026
Merged

fix: optimize parsing V3.1 documents by reducing GetLocation method allocation on hot path(#2748) #2750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions ...ark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
```

BenchmarkDotNet v0.15.6, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.417
[Host] : .NET 8.0.23 (8.0.23, 8.0.2325.60607), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.23 (8.0.23, 8.0.2325.60607), X64 RyuJIT x86-64-v3
BenchmarkDotNet v0.15.6, Windows 11 (10.0.26200.7781)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 8.0.418
[Host] : .NET 8.0.24 (8.0.24, 8.0.2426.7010), X64 RyuJIT x86-64-v4
ShortRun : .NET 8.0.24 (8.0.24, 8.0.2426.7010), X64 RyuJIT x86-64-v4

Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3

```
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated |
|------------- |-------------:|--------------:|------------:|-----------:|-----------:|----------:|-------------:|
| PetStoreYaml | 501.7 μs | 528.15 μs | 28.95 μs | 19.5313 | 3.9063 | - | 360.93 KB |
| PetStoreJson | 210.6 μs | 17.50 μs | 0.96 μs | 12.6953 | 3.9063 | - | 222.79 KB |
| GHESYaml | 949,343.9 μs | 130,962.66 μs | 7,178.51 μs | 24000.0000 | 19000.0000 | 3000.0000 | 345282.95 KB |
| GHESJson | 416,644.6 μs | 110,860.35 μs | 6,076.63 μs | 13000.0000 | 9000.0000 | 2000.0000 | 206802.12 KB |
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated |
|------------- |---------------:|----------------:|-------------:|-----------:|-----------:|----------:|-------------:|
| PetStoreYaml | 881.3 μs | 2,728.99 μs | 149.58 μs | 54.6875 | 7.8125 | - | 360.94 KB |
| PetStoreJson | 190.5 μs | 60.34 μs | 3.31 μs | 36.1328 | 7.8125 | - | 223.09 KB |
| GHESYaml | 1,041,152.3 μs | 128,977.22 μs | 7,069.68 μs | 60000.0000 | 23000.0000 | 4000.0000 | 345284.59 KB |
| GHESJson | 464,809.9 μs | 253,196.41 μs | 13,878.55 μs | 33000.0000 | 12000.0000 | 2000.0000 | 206806.4 KB |
| GHESNextYaml | 1,268,192.5 μs | 1,209,245.90 μs | 66,282.85 μs | 91000.0000 | 22000.0000 | 3000.0000 | 541026.33 KB |
| GHESNextJson | 749,410.0 μs | 1,057,535.55 μs | 57,967.09 μs | 65000.0000 | 20000.0000 | 2000.0000 | 406224.57 KB |
10 changes: 6 additions & 4 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
Method,Job,AnalyzeLaunchVariance,EvaluateOverhead,MaxAbsoluteError,MaxRelativeError,MinInvokeCount,MinIterationTime,OutlierMode,Affinity,EnvironmentVariables,Jit,LargeAddressAware,Platform,PowerPlanMode,Runtime,AllowVeryLargeObjects,Concurrent,CpuGroups,Force,HeapAffinitizeMask,HeapCount,NoAffinitize,RetainVm,Server,Arguments,BuildConfiguration,Clock,EngineFactory,NuGetReferences,Toolchain,IsMutator,InvocationCount,IterationCount,IterationTime,LaunchCount,MaxIterationCount,MaxWarmupIterationCount,MemoryRandomization,MinIterationCount,MinWarmupIterationCount,RunStrategy,UnrollFactor,WarmupCount,Mean,Error,StdDev,Gen0,Gen1,Gen2,Allocated
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,501.7 μs,528.15 μs,28.95 μs,19.5313,3.9063,0.0000,360.93 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,210.6 μs,17.50 μs,0.96 μs,12.6953,3.9063,0.0000,222.79 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"949,343.9 μs","130,962.66 μs","7,178.51 μs",24000.0000,19000.0000,3000.0000,345282.95 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,1111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"416,644.6 μs","110,860.35 μs","6,076.63 μs",13000.0000,9000.0000,2000.0000,206802.12 KB
PetStoreYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,881.3 μs,"2,728.99 μs",149.58 μs,54.6875,7.8125,0.0000,360.94 KB
PetStoreJson,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,190.5 μs,60.34 μs,3.31 μs,36.1328,7.8125,0.0000,223.09 KB
GHESYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,041,152.3 μs","128,977.22 μs","7,069.68 μs",60000.0000,23000.0000,4000.0000,345284.59 KB
GHESJson,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"464,809.9 μs","253,196.41 μs","13,878.55 μs",33000.0000,12000.0000,2000.0000,206806.4 KB
GHESNextYaml,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"1,268,192.5 μs","1,209,245.90 μs","66,282.85 μs",91000.0000,22000.0000,3000.0000,541026.33 KB
GHESNextJson,ShortRun,False,Default,Default,Default,Default,Default,Default,11111111,Empty,RyuJit,Default,X64,8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c,.NET 8.0,False,True,False,True,Default,Default,False,False,False,Default,Default,Default,Default,Default,Default,Default,Default,3,Default,1,Default,Default,Default,Default,Default,Default,16,3,"749,410.0 μs","1,057,535.55 μs","57,967.09 μs",65000.0000,20000.0000,2000.0000,406224.57 KB
24 changes: 13 additions & 11 deletions performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang='en'>
<head>
<meta charset='utf-8' />
<title>performance.Descriptions-20260218-152302</title>
<title>performance.Descriptions-20260224-161326</title>

<style type="text/css">
table { border-collapse: collapse; display: block; width: 100%; overflow: auto; }
Expand All @@ -13,23 +13,25 @@
</head>
<body>
<pre><code>
BenchmarkDotNet v0.15.6, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.417
[Host] : .NET 8.0.23 (8.0.23, 8.0.2325.60607), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.23 (8.0.23, 8.0.2325.60607), X64 RyuJIT x86-64-v3
BenchmarkDotNet v0.15.6, Windows 11 (10.0.26200.7781)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 8.0.418
[Host] : .NET 8.0.24 (8.0.24, 8.0.2426.7010), X64 RyuJIT x86-64-v4
ShortRun : .NET 8.0.24 (8.0.24, 8.0.2426.7010), X64 RyuJIT x86-64-v4
</code></pre>
<pre><code>Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3
</code></pre>

<table>
<thead><tr><th>Method</th><th>Mean </th><th>Error </th><th>StdDev</th><th>Gen0</th><th>Gen1</th><th>Gen2</th><th>Allocated</th>
<thead><tr><th>Method</th><th>Mean </th><th>Error </th><th>StdDev</th><th>Gen0</th><th>Gen1</th><th>Gen2</th><th>Allocated</th>
</tr>
</thead><tbody><tr><td>PetStoreYaml</td><td>501.7 &mu;s</td><td>528.15 &mu;s</td><td>28.95 &mu;s</td><td>19.5313</td><td>3.9063</td><td>-</td><td>360.93 KB</td>
</tr><tr><td>PetStoreJson</td><td>210.6 &mu;s</td><td>17.50 &mu;s</td><td>0.96 &mu;s</td><td>12.6953</td><td>3.9063</td><td>-</td><td>222.79 KB</td>
</tr><tr><td>GHESYaml</td><td>949,343.9 &mu;s</td><td>130,962.66 &mu;s</td><td>7,178.51 &mu;s</td><td>24000.0000</td><td>19000.0000</td><td>3000.0000</td><td>345282.95 KB</td>
</tr><tr><td>GHESJson</td><td>416,644.6 &mu;s</td><td>110,860.35 &mu;s</td><td>6,076.63 &mu;s</td><td>13000.0000</td><td>9000.0000</td><td>2000.0000</td><td>206802.12 KB</td>
</thead><tbody><tr><td>PetStoreYaml</td><td>881.3 &mu;s</td><td>2,728.99 &mu;s</td><td>149.58 &mu;s</td><td>54.6875</td><td>7.8125</td><td>-</td><td>360.94 KB</td>
</tr><tr><td>PetStoreJson</td><td>190.5 &mu;s</td><td>60.34 &mu;s</td><td>3.31 &mu;s</td><td>36.1328</td><td>7.8125</td><td>-</td><td>223.09 KB</td>
</tr><tr><td>GHESYaml</td><td>1,041,152.3 &mu;s</td><td>128,977.22 &mu;s</td><td>7,069.68 &mu;s</td><td>60000.0000</td><td>23000.0000</td><td>4000.0000</td><td>345284.59 KB</td>
</tr><tr><td>GHESJson</td><td>464,809.9 &mu;s</td><td>253,196.41 &mu;s</td><td>13,878.55 &mu;s</td><td>33000.0000</td><td>12000.0000</td><td>2000.0000</td><td>206806.4 KB</td>
</tr><tr><td>GHESNextYaml</td><td>1,268,192.5 &mu;s</td><td>1,209,245.90 &mu;s</td><td>66,282.85 &mu;s</td><td>91000.0000</td><td>22000.0000</td><td>3000.0000</td><td>541026.33 KB</td>
</tr><tr><td>GHESNextJson</td><td>749,410.0 &mu;s</td><td>1,057,535.55 &mu;s</td><td>57,967.09 &mu;s</td><td>65000.0000</td><td>20000.0000</td><td>2000.0000</td><td>406224.57 KB</td>
</tr></tbody></table>
</body>
</html>
2 changes: 1 addition & 1 deletion performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.json
View file
Open in desktop

Large diffs are not rendered by default.

70 changes: 35 additions & 35 deletions ...mark/BenchmarkDotNet.Artifacts/results/performance.EmptyModels-report-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,42 @@
```

BenchmarkDotNet v0.15.6, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.417
[Host] : .NET 8.0.23 (8.0.23, 8.0.2325.60607), X64 RyuJIT x86-64-v3
ShortRun : .NET 8.0.23 (8.0.23, 8.0.2325.60607), X64 RyuJIT x86-64-v3
BenchmarkDotNet v0.15.6, Windows 11 (10.0.26200.7781)
11th Gen Intel Core i7-1185G7 3.00GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 8.0.418
[Host] : .NET 8.0.24 (8.0.24, 8.0.2426.7010), X64 RyuJIT x86-64-v4
ShortRun : .NET 8.0.24 (8.0.24, 8.0.2426.7010), X64 RyuJIT x86-64-v4

Job=ShortRun IterationCount=3 LaunchCount=1
WarmupCount=3

```
| Method | Mean | Error | StdDev | Gen0 | Allocated |
|---------------------------- |-------------:|------------:|----------:|-------:|----------:|
| EmptyApiCallback | 9.685 ns | 17.7937 ns | 0.9753 ns | 0.0019 | 32 B |
| EmptyApiComponents | 11.627 ns | 10.7777 ns | 0.5908 ns | 0.0062 | 104 B |
| EmptyApiContact | 14.086 ns | 14.8829 ns | 0.8158 ns | 0.0029 | 48 B |
| EmptyApiDiscriminator | 11.069 ns | 6.1582 ns | 0.3376 ns | 0.0024 | 40 B |
| EmptyDocument | 1,483.353 ns | 138.3191 ns | 7.5817 ns | 0.0668 | 1136 B |
| EmptyApiEncoding | 11.392 ns | 8.8333 ns | 0.4842 ns | 0.0033 | 56 B |
| EmptyApiExample | 11.386 ns | 18.8529 ns | 1.0334 ns | 0.0033 | 56 B |
| EmptyApiExternalDocs | 12.680 ns | 19.1225 ns | 1.0482 ns | 0.0024 | 40 B |
| EmptyApiHeader | 9.105 ns | 5.0905 ns | 0.2790 ns | 0.0048 | 80 B |
| EmptyApiInfo | 10.826 ns | 4.2315 ns | 0.2319 ns | 0.0048 | 80 B |
| EmptyApiLicense | 11.953 ns | 23.1808 ns | 1.2706 ns | 0.0029 | 48 B |
| EmptyApiLink | 8.932 ns | 2.4237 ns | 0.1328 ns | 0.0043 | 72 B |
| EmptyApiMediaType | 16.192 ns | 2.7983 ns | 0.1534 ns | 0.0033 | 56 B |
| EmptyApiOAuthFlow | 12.778 ns | 12.4107 ns | 0.6803 ns | 0.0033 | 56 B |
| EmptyApiOAuthFlows | 7.628 ns | 2.4289 ns | 0.1331 ns | 0.0033 | 56 B |
| EmptyApiOperation | 73.545 ns | 34.5706 ns | 1.8949 ns | 0.0224 | 376 B |
| EmptyApiParameter | 15.957 ns | 33.0382 ns | 1.8109 ns | 0.0057 | 96 B |
| EmptyApiPathItem | 8.331 ns | 8.9214 ns | 0.4890 ns | 0.0038 | 64 B |
| EmptyApiPaths | 62.495 ns | 0.3726 ns | 0.0204 ns | 0.0148 | 248 B |
| EmptyApiRequestBody | 13.819 ns | 28.7503 ns | 1.5759 ns | 0.0029 | 48 B |
| EmptyApiResponse | 14.121 ns | 12.2665 ns | 0.6724 ns | 0.0033 | 56 B |
| EmptyApiResponses | 57.201 ns | 3.1653 ns | 0.1735 ns | 0.0148 | 248 B |
| EmptyApiSchema | 27.815 ns | 19.2152 ns | 1.0532 ns | 0.0249 | 416 B |
| EmptyApiSecurityRequirement | 15.751 ns | 10.7910 ns | 0.5915 ns | 0.0062 | 104 B |
| EmptyApiSecurityScheme | 11.171 ns | 3.6777 ns | 0.2016 ns | 0.0053 | 88 B |
| EmptyApiServer | 13.892 ns | 9.7265 ns | 0.5331 ns | 0.0029 | 48 B |
| EmptyApiServerVariable | 7.507 ns | 3.2572 ns | 0.1785 ns | 0.0029 | 48 B |
| EmptyApiTag | 11.666 ns | 9.0815 ns | 0.4978 ns | 0.0029 | 48 B |
| Method | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---------------------------- |-----------:|-----------:|----------:|-------:|-------:|----------:|
| EmptyApiCallback | 4.394 ns | 7.7398 ns | 0.4242 ns | 0.0051 | - | 32 B |
| EmptyApiComponents | 6.145 ns | 3.1822 ns | 0.1744 ns | 0.0166 | - | 104 B |
| EmptyApiContact | 4.473 ns | 1.8228 ns | 0.0999 ns | 0.0076 | - | 48 B |
| EmptyApiDiscriminator | 4.484 ns | 5.5910 ns | 0.3065 ns | 0.0064 | - | 40 B |
| EmptyDocument | 441.153 ns | 74.1464 ns | 4.0642 ns | 0.1807 | 0.0005 | 1136 B |
| EmptyApiEncoding | 4.876 ns | 1.9665 ns | 0.1078 ns | 0.0089 | - | 56 B |
| EmptyApiExample | 4.982 ns | 0.8982 ns | 0.0492 ns | 0.0089 | - | 56 B |
| EmptyApiExternalDocs | 4.224 ns | 2.6263 ns | 0.1440 ns | 0.0064 | - | 40 B |
| EmptyApiHeader | 5.617 ns | 7.1086 ns | 0.3896 ns | 0.0127 | - | 80 B |
| EmptyApiInfo | 5.978 ns | 8.8949 ns | 0.4876 ns | 0.0127 | - | 80 B |
| EmptyApiLicense | 5.116 ns | 2.2648 ns | 0.1241 ns | 0.0076 | - | 48 B |
| EmptyApiLink | 5.791 ns | 6.7182 ns | 0.3682 ns | 0.0115 | - | 72 B |
| EmptyApiMediaType | 5.533 ns | 2.5596 ns | 0.1403 ns | 0.0089 | - | 56 B |
| EmptyApiOAuthFlow | 5.220 ns | 0.5278 ns | 0.0289 ns | 0.0089 | - | 56 B |
| EmptyApiOAuthFlows | 5.915 ns | 5.5310 ns | 0.3032 ns | 0.0089 | - | 56 B |
| EmptyApiOperation | 67.753 ns | 7.6830 ns | 0.4211 ns | 0.0598 | - | 376 B |
| EmptyApiParameter | 7.363 ns | 20.7768 ns | 1.1388 ns | 0.0153 | - | 96 B |
| EmptyApiPathItem | 5.958 ns | 8.9121 ns | 0.4885 ns | 0.0102 | - | 64 B |
| EmptyApiPaths | 60.404 ns | 11.7043 ns | 0.6416 ns | 0.0395 | - | 248 B |
| EmptyApiRequestBody | 4.739 ns | 5.1058 ns | 0.2799 ns | 0.0076 | - | 48 B |
| EmptyApiResponse | 5.912 ns | 17.1013 ns | 0.9374 ns | 0.0089 | - | 56 B |
| EmptyApiResponses | 58.344 ns | 31.8750 ns | 1.7472 ns | 0.0395 | - | 248 B |
| EmptyApiSchema | 15.576 ns | 8.9314 ns | 0.4896 ns | 0.0663 | - | 416 B |
| EmptyApiSecurityRequirement | 11.522 ns | 0.8412 ns | 0.0461 ns | 0.0166 | - | 104 B |
| EmptyApiSecurityScheme | 6.179 ns | 9.7926 ns | 0.5368 ns | 0.0140 | - | 88 B |
| EmptyApiServer | 4.518 ns | 1.1882 ns | 0.0651 ns | 0.0076 | - | 48 B |
| EmptyApiServerVariable | 4.984 ns | 12.5509 ns | 0.6880 ns | 0.0076 | - | 48 B |
| EmptyApiTag | 5.830 ns | 36.9629 ns | 2.0261 ns | 0.0076 | - | 48 B |
Loading
Loading