Make chunk param of WritableStreamDefaultWriter.write and TransformStreamDefaultController.enqueue non-optional#2452
Merged
github-actions[bot] merged 3 commits intomicrosoft:mainfrom Mar 18, 2026
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Bashamega
suggested changes
Mar 17, 2026
Contributor
Bashamega
left a comment
There was a problem hiding this comment.
Please do not format the jsonc file, it creates extra diffs
Collaborator
|
Thanks all! LGTM |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #2425
The issue was first mentioned in #1682
Test script
This script demonstrates that calling
enqueue()without arguments is behaviorally identical toenqueue(undefined). This confirms that allowing the omission of arguments in these methods poses a risk to type safety, unless the stream's generic type is explicitly defined to includeundefinedorvoid.I successfully ran the script on Node.js v24.13.1, Chrome 145.0.7632.160, Firefox 148.0.2, Safari 26.3.1