Skip to content

Make chunk param of WritableStreamDefaultWriter.write and TransformStreamDefaultController.enqueue non-optional #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 3 commits into from
Mar 18, 2026
Merged

Make chunk param of WritableStreamDefaultWriter.write and TransformStreamDefaultController.enqueue non-optional #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f977eac
Make chunk param of WritableStreamDefaultWriter.write non-optional
ikeyan Mar 17, 2026
635fe69
Make chunk param of TransformStreamDefaultController.enqueue non-opti…
ikeyan Mar 17, 2026
55f1acb
Undo the format change
ikeyan Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions baselines/audioworklet.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,7 +1227,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -1537,7 +1537,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37250,7 +37250,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -42094,7 +42094,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9313,7 +9313,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12766,7 +12766,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8844,7 +8844,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12305,7 +12305,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/audioworklet.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -1534,7 +1534,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37224,7 +37224,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -42068,7 +42068,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9310,7 +9310,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12763,7 +12763,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8841,7 +8841,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12302,7 +12302,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10468,7 +10468,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -14251,7 +14251,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/audioworklet.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -1534,7 +1534,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37247,7 +37247,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -42091,7 +42091,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9310,7 +9310,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12763,7 +12763,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8841,7 +8841,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12302,7 +12302,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10468,7 +10468,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -14251,7 +14251,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.9/audioworklet.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -1534,7 +1534,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.9/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37247,7 +37247,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -42091,7 +42091,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.9/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9310,7 +9310,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12763,7 +12763,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.9/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8841,7 +8841,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -12302,7 +12302,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.9/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10468,7 +10468,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -14251,7 +14251,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
4 changes: 2 additions & 2 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10471,7 +10471,7 @@ interface TransformStreamDefaultController<O = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TransformStreamDefaultController/enqueue)
*/
enqueue(chunk?: O): void;
enqueue(chunk: O): void;
/**
* The **`error()`** method of the TransformStreamDefaultController interface errors both sides of the stream. Any further interactions with it will fail with the given error message, and any chunks in the queue will be discarded.
*
Expand Down Expand Up @@ -14254,7 +14254,7 @@ interface WritableStreamDefaultWriter<W = any> {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WritableStreamDefaultWriter/write)
*/
write(chunk?: W): Promise<void>;
write(chunk: W): Promise<void>;
}

declare var WritableStreamDefaultWriter: {
Expand Down
2 changes: 2 additions & 0 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2323,6 +2323,7 @@
"param": [
{
"name": "chunk",
"optional": false,
"overrideType": "W"
}
]
Expand Down Expand Up @@ -2408,6 +2409,7 @@
"param": [
{
"name": "chunk",
"optional": false,
"overrideType": "O"
}
]
Expand Down
Loading