Fix incorrect MDN links for requestAnimationFrame/cancelAnimationFrame#2390
Fix incorrect MDN links for requestAnimationFrame/cancelAnimationFrame#2390Mohitlikestocode wants to merge 3 commits intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Dear cloude code or copilot or whatever AI agent, please don't modify mdn.json, it's written in the doc... |
|
Hey @saschanaz! Very sorry, I didn’t know I first edited Should I instead add an override (e.g. in |
|
This is really MDN issue that duplicates the same documentation for the same global function. I argued in mdn/content#39951 and they dismissed. I think maybe time to argue again? |
What does this PR do?
Fixes incorrect MDN reference links for the animation frame APIs in
baselines/dom.generated.d.ts.Fixes #2154
What was wrong?
The JSDoc MDN references for:
requestAnimationFramecancelAnimationFramewere pointing to the
DedicatedWorkerGlobalScopeMDN pages, which is misleading when using these APIs as standardWindowglobals (e.g.window.requestAnimationFrame(...),window.cancelAnimationFrame(...)).What changed?
Updated the MDN reference URLs to the correct
Windowpages:https://developer.mozilla.org/docs/Web/API/Window/requestAnimationFramehttps://developer.mozilla.org/docs/Web/API/Window/cancelAnimationFrameImpact
This is a documentation/reference-only change: