Manually update to idl@3.74.0#2451
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
tsgo fails? |
| type DeepPartial<T> = T extends any[] | ||
| ? Record<number, DeepPartial<T>> | DeepPartial<T>[] | ||
| : T extends object | ||
| ? { [K in keyof T]?: DeepPartial<T[K]> } | ||
| : T; |
There was a problem hiding this comment.
tsgo hates this change, should I care? @jakebailey
There was a problem hiding this comment.
microsoft/typescript-go#2609, but --stableTypeOrdering doesn't seem to help.
There was a problem hiding this comment.
The option brings ts6 to use the ts7 ordering.
So in this case it would only "activate" the bug in ts6, too.
But also you could try to fix the crash with ts6 without ts7
There was a problem hiding this comment.
Hmm, interesting. TS6 hates that too regardless of the flag.
There was a problem hiding this comment.
I'm sure that linked issue is separate; it's a very generic issue.
A lot of these types only worked accidentally :\
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
3 participants
Also ran
npm audit fix.