Fix private properties not being allowed in optional chains

[Psychpsyo]

Fixes #42734

This makes it so that expressions of the form foo?.#bar or foo?.bar.#baz are no longer seen as invalid, since the relevant JavaScript standards allow these by now and TypeScript claims to be a superset of JavaScript.
Specifically, private properties are now allowed inside an optional chain.
This syntax is allowed since tc39/proposal-class-fields#301

The added this.a = this; in privateIdentifierChain.1.ts is there so that line 14, this?.a.#b;, does not error because a might be undefined, as that's not what this file is testing for.

I'm sorry for fixing an issue that is not in the backlog, but this is bothering me personally and has existed for years at this point.
Otherwise, I have verified that:

• Code is up-to-date with the main branch
• You've successfully run hereby runtests locally
• There are new or updated unit tests validating the change

[Psychpsyo]

@microsoft-github-policy-service agree

[jakebailey]

Coming back to this, this PR is missing a few things that would make this work:

• A test that the downlevelling works, so set the test's target to @target: esnext,es2015.
• A new test that verifies some sort of cross-class error happens, e.g. copy and paste the class in the test to B, and there should be type errors since A is the wrong class.

[Psychpsyo]

Coming back to this, this PR is missing a few things that would make this work:

* A test that the downlevelling works, so set the test's target to `@target: esnext,es2015`.

* A new test that verifies some sort of cross-class error happens, e.g. copy and paste the class in the test to `B`, and there should be type errors since `A` is the wrong class.

Done that now.

[jakebailey]

I suspect we need sort of version check to verify that the syntax is available to the syntax we're emitting, like a new grammar check in the checker to verify this.

Unless you're saying that this syntax has always been allowed since feature was standardized?

[typescript-bot]

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

• For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
• Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
• Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate