Skip to content

Fix optional property quick info showing redundant '| undefined'#62084

Closed
sw1tch3roo wants to merge 2 commits intomicrosoft:mainfrom
sw1tch3roo:fix/optional-property-quickinfo-consistency
Closed

Fix optional property quick info showing redundant '| undefined'#62084
sw1tch3roo wants to merge 2 commits intomicrosoft:mainfrom
sw1tch3roo:fix/optional-property-quickinfo-consistency

Conversation

@sw1tch3roo
Copy link
Copy Markdown

Fixes #61954

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jul 16, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 16, 2025
@sw1tch3roo sw1tch3roo force-pushed the fix/optional-property-quickinfo-consistency branch from 0ab5c4a to d4b6731 Compare July 17, 2025 15:44
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the change I had in mind (or at least, it's not testing the right stuff). The specific thing I'm bringing up is about hovering over Options itself when hover verbosity is enabled. It's not about quick info on accesses of specific properties.

While it's true that I think we should only show ? and not introduce the undefined type in these cases, you'll notice on the issue that the property border has a strangely different type compared to color.

@github-project-automation github-project-automation bot moved this from Not started to Waiting on author in PR Backlog Jul 23, 2025
@github-project-automation github-project-automation bot moved this from Waiting on author to Done in PR Backlog Mar 24, 2026
@typescript-bot
Copy link
Copy Markdown
Collaborator

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Inconsistent quick info on optional properties when supporting hover verbosity

5 participants