Fix optional property quick info showing redundant '| undefined'#62084
Fix optional property quick info showing redundant '| undefined'#62084sw1tch3roo wants to merge 2 commits intomicrosoft:mainfrom
Conversation
0ab5c4a to
d4b6731
Compare
There was a problem hiding this comment.
I don't think this is the change I had in mind (or at least, it's not testing the right stuff). The specific thing I'm bringing up is about hovering over Options itself when hover verbosity is enabled. It's not about quick info on accesses of specific properties.
While it's true that I think we should only show ? and not introduce the undefined type in these cases, you'll notice on the issue that the property border has a strangely different type compared to color.
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
Fixes #61954