Fix stack overflow when checking circular binding element references #62999
+228
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack overflow when
strictNullChecksis enabled and a destructuring pattern initializer references its own binding elements.Root cause:
getBindingElementTypeFromParentTypecallsgetTypeOfInitializer()to check if the initializer could beundefined. This triggers full type checking of the object literal, which resolves the shorthand propertyf, which requires the type of binding elementf— creating infinite recursion.Fix: Use
getQuickTypeOfExpression()or cachedresolvedTypeinstead ofgetTypeOfInitializer(). If no cached type is available, skip theundefinedfiltering optimization rather than risk circularity.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.