Fix resume error for old profile-based sessions #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resuming sessions created before the profiles feature was removed, users encountered: Error resuming session: config_manager and profile_loader required for profile mode Root cause: _prepare_resume_context() didn't default to a bundle when no bundle was found in saved session metadata. Old profile-based sessions have no 'bundle' key, so bundle_name remained None, causing resolve_config() to fall into 'profile mode' which requires the now-removed profile_loader. Fix: Default to 'foundation' bundle when no bundle is found in saved session metadata. This matches the fallback pattern already used in run.py and tool.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When resuming sessions created before the profiles feature was removed, users encountered:
Root Cause
The
_prepare_resume_context()function insession.pydidn't default to a bundle when no bundle was found in saved session metadata. Old profile-based sessions have nobundlekey in their metadata, sobundle_nameremainedNone, causingresolve_config()to fall into "profile mode" which requiresprofile_loader- a component that no longer exists since profiles were removed.Solution
Default to the "foundation" bundle when no bundle is found in saved session metadata. This matches the fallback pattern already used in
run.pyandtool.py.Changes
amplifier_app_cli/commands/session.py: Added fallback to "foundation" bundle after checking for saved bundle in session metadataTesting