Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "address code review feedback",
"packageName": "@fluentui-react-native/menu",
"email": "jasonmo@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "address code review feedback",
"packageName": "@fluentui-react-native/overflow",
"email": "jasonmo@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "address code review feedback",
"packageName": "@fluentui-react-native/tablist",
"email": "jasonmo@microsoft.com",
"dependentChangeType": "none"
}
1 change: 0 additions & 1 deletion packages/components/Menu/src/MenuTrigger/useMergeRefs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export function useMergedRefs<T>(...refs: (React.Ref<T> | undefined)[]): RefObje
}
}
},

[...refs],
) as unknown as RefObjectFunction<T>;

Expand Down
1 change: 0 additions & 1 deletion packages/components/TabList/src/TabList/useTabList.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ export const useTabList = (props: TabListProps): TabListInfo => {
setFocusedTabRef(ref);
}
}
// Disable exhaustive-deps warning because this hook should only run once 'isSelectedTabDisabled' dependency changes.
}, [isSelectedTabDisabled]);

// win32 only prop used to implemement CTRL + TAB shortcut native to windows tab components
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export function useAnimatedIndicatorStyles(props: AnimatedIndicatorProps): Anima
const indicatorScale = React.useRef(new Animated.Value(1)).current;

// Save the initial selected layout, this shouldn't update after the first render.

const startingKey = React.useMemo(() => selectedKey, []);

React.useEffect(() => {
Expand Down
1 change: 0 additions & 1 deletion packages/experimental/Overflow/src/Overflow/useOverflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ export function useOverflow(props: OverflowProps): OverflowInfo {
overflowManager.removeItem(id);
},
// overflowManager is not needed as a dependency, due to being attached to a ref

[overflowItemUpdateCallbacks],
);

Expand Down
9 changes: 9 additions & 0 deletions scripts/src/utils/env.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
/**
* Lage doesn't support cleanly passing parameters to sub scripts, so this allows our scripts that
* support a "fix" mode to be toggled via an environment variable. This allows things like lint --fix or
* lint-package --fix to be run from the root level without having to have duplicate scripts entries for
* each package.
*/

// env variable to use
export const FIX_ENV_VAR = 'FURN_FIX_MODE';

// standard helper function to check for fix mode
export function isFixMode(fromParam?: boolean): boolean {
return fromParam || Boolean(process.env[FIX_ENV_VAR]);
}
Loading