Refactor: lazy initialization for device_detector singleton #1831
+25
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report (presidio-anonymizer)
This PR does not seem to contain any modification to coverable code. |
Coverage report (presidio-structured)
This PR does not seem to contain any modification to coverable code. |
Coverage report (presidio-cli)
This PR does not seem to contain any modification to coverable code. |
Coverage report (presidio-image-redactor)
This PR does not seem to contain any modification to coverable code. |
Coverage report (presidio-analyzer)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the device_detector singleton initialization from eager (at module import time) to lazy (on first access) using Python's module-level __getattr__ mechanism. This aims to defer expensive GPU detection until the singleton is actually used.
Changes:
- Implemented lazy initialization using module-level
__getattr__to defer device detection - Simplified exception handling in
_detect()method by catching all exceptions in one block - Updated module documentation to reflect lazy initialization pattern
presidio-analyzer/presidio_analyzer/nlp_engine/device_detector.py
Outdated
Show resolved
Hide resolved
omri374
reviewed
Jan 14, 2026
…nsformersRecognizer to use it
SharonHart
reviewed
Jan 15, 2026
SharonHart
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Defer DeviceDetector creation until first use to avoid unnecessary GPU detection at import time.
Issue reference
Fixes #XX
Checklist