Fix rnw-dependencies.ps1 Node.js installation failures #15548
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vineethkuttan
left a comment
vineethkuttan
left a comment
There was a problem hiding this comment.
You have to change the in samples and update the website
https://microsoft.github.io/react-native-windows/docs/rnw-dependencies
| Tags = @('appDev'); | ||
| Valid = { CheckNode; } | ||
| Install = { WinGetInstall OpenJS.NodeJS.LTS "22.14.0" }; | ||
| Install = { WinGetInstall OpenJS.NodeJS.LTS }; |
Contributor
There was a problem hiding this comment.
node 22's latest version updated to 22.22.0
removing version will install node 24 I believe, because that is the latest LTS.
replace 22.14.0 with 22.22.0
| } | ||
|
|
||
| # Refresh PATH environment variable to pick up newly installed tools | ||
| $env:Path = [System.Environment]::GetEnvironmentVariable("Path","Machine") + ";" + [System.Environment]::GetEnvironmentVariable("Path","User") |
Contributor
There was a problem hiding this comment.
This change is not needed I guess, cause the script is designed in a way to close the terminal after it finishes.
So refreshing path is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rnw-dependencies.ps1 script fails to install Node.js with the error:
WARNING: There was a problem trying to install Node.js (LTS, >= 22.0)Type of Change
Why
OpenJS.NodeJS.LTS, but this is a rolling package that now only contains 24.x versions (22.14.0 exists inOpenJS.NodeJS.22, not.LTS)Resolves [Add Relevant Issue Here]
What
Screenshots
Testing
tested on a new vm .Worked as expected
Changelog
Should this change be included in the release notes: no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow