-
Notifications
You must be signed in to change notification settings - Fork 114
Fix indentation in isFabricInstance function #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation in isFabricInstance function #3918
Conversation
….3.0 (#3917) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
@copilot Target this branch: renovate/prettier-3.x-lockfile |
Co-authored-by: tido64 <[email protected]>
I don't have permission to change the PR base branch directly. Could you please retarget the PR to the |
|
@copilot This PR now targets the correct branch. Restore the code comments and rebase the branch to get rid of superfluous commits. |
Co-authored-by: tido64 <[email protected]>
Restored the Regarding rebasing to clean up commits: I don't have permission to perform |
|
@copilot This PR no longer fixes the indentations. Check again with |
Co-authored-by: tido64 <[email protected]>
Fixed in commit dc4a5cb. The indentation is now corrected to match Prettier 3.7.4 formatting (from the base branch). Both conditions now have consistent indentation without the extra spaces on the second line. Verified with |
Description
CI detected uncommitted formatting changes in
packages/test-app/src/internal/index.ts. TheisFabricInstancefunction had inline@ts-expect-errorcomments with inconsistent indentation.Fixed the indentation while preserving the necessary TypeScript error suppression comments:
The fix removes the extra 2 spaces of indentation on the second condition line (lines 27-28), ensuring both conditions have consistent indentation. The
@ts-expect-errorcomments are preserved as they document why these property accesses are necessary (referencing the React Native Fabric implementation). The indentation now follows Prettier 3.7.4 formatting rules from the base branch.Test plan
Run
yarn format && git diff --exit-codeto verify no uncommitted formatting changes remain.Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.