Migrate rush-lib from deprecated inquirer to @inquirer/* modular packages#5775
Draft
Migrate rush-lib from deprecated inquirer to @inquirer/* modular packages#5775
inquirer to @inquirer/* modular packages#5775Conversation
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/489f4c8b-19ff-4dd2-9198-b68f948590c4 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
…ynamic imports Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/489f4c8b-19ff-4dd2-9198-b68f948590c4 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/489f4c8b-19ff-4dd2-9198-b68f948590c4 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
dmichon-msft
April 16, 2026 00:37
View session
dmichon-msft
requested changes
Apr 16, 2026
| import type { Interface } from 'node:readline'; | ||
|
|
||
| // Modified from the choice list prompt in inquirer: | ||
| // https://github.com/SBoudrias/Inquirer.js/blob/inquirer%407.3.3/packages/inquirer/lib/prompts/list.js |
Contributor
There was a problem hiding this comment.
@copilot I had thought this prompt might do something special, but it sounds like the new @inquirer/search prompt is probably equivalent? In which case, go ahead and use that.
Contributor
Author
There was a problem hiding this comment.
Done in e74a019. SearchListPrompt.ts is deleted entirely — InteractiveUpgrader now calls @inquirer/search directly, passing a synchronous source function that filters the static project list by plain package name. @inquirer/core and figures are removed as direct dependencies.
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/f1344299-0cfc-4f05-a56e-7808031c327e Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/0e45eb67-e915-4132-9b66-5a947b83d8c1 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/ac1cae6c-9bf6-43b4-9356-93df56d4ad6b Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangeAction.ts,InteractiveUpgradeUI.ts,InteractiveUpgrader.tsoff deprecatedinquirerSearchListPromptwith@inquirer/searchpackage.json(add@inquirer/search, removeinquirer/@types/inquirer/figures)nonbrowser-approved-packages.jsonorigin/mainversions ofpnpm-lock.yamlandrepo-state.json(including0ab0c12add— lodash removal)rush updateto produce lockfiles consistent with current main + new@inquirer/searchdependency