Bump flatted from 3.3.3 to 3.4.2 in /dotnet/samples/Demos/ProcessFrameworkWithSignalR/src/ProcessFramework.Aspire.SignalR.ReactFrontend#13700
Conversation
Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.3 to 3.4.2. - [Commits](WebReflection/flatted@v3.3.3...v3.4.2) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Automated Code Review
Reviewers: 4 | Confidence: 92%
✓ Correctness
This PR only modifies auto-generated lockfiles (package-lock.json and yarn.lock). The changes remove 'peer: true' flags from packages that are direct or dev dependencies in package.json (react, react-dom,
@fluentui/react-components,@types/react,@types/react-dom, typescript, eslint, vite, etc.), which is correct. The only version change is flated 3.3 → 3.4.2, a patch-level bump of a transitive dev dependency. No correctness issues found.
✓ Security Reliability
This PR updates lockfiles (package-lock.json and yarn.lock) for a React frontend sample app. The changes are: (1) removing
"peer": trueflags from numerous packages, which means these packages are now treated as direct/transitive dependencies rather than peer dependencies — this is consistent with them already being listed in package.json's dependencies/devDependencies, and (2) bumpingflattedfrom 3.3.3 to 3.4.2, a minor version update of a dev dependency used by flat-cache/eslint. No security or reliability concerns identified. The integrity hashes are present and match the expected format for the declared versions. No new dependencies are introduced, no secrets are exposed, and no code changes are involved.
✓ Test Coverage
This PR modifies only lockfiles (package-lock.json and yarn.lock) for a React frontend demo sample. The changes remove
"peer": trueflags from numerous dependencies (promoting them from peer to direct/transitive dependencies) and bumpflatedfrom 3.3.3 to 3.4.2. These are purely dependency metadata changes in lockfiles within a demo/sample project — no application code, library code, or test code is added or modified. There is no new or changed behavior that would require test coverage.
✓ Design Approach
This PR is a lockfile-only update: it removes stale
"peer": trueannotations from packages that are explicitly listed as direct dependencies in package.json (react, react-dom,@fluentui/react-components,@types/react,@types/react-dom, etc.), and bumpsflattedfrom 3.3.3 → 3.4.2 in both lock files. The"peer": trueremovals are correct — those packages genuinely belong todependencies/devDependenciesin package.json, so npm should not mark them as peer-only. Theflattedbump is a minor dev-dependency patch. One pre-existing structural concern (not introduced by this PR): the project maintains bothpackage-lock.jsonandyarn.locksimultaneously, which means the two lock files can diverge silently depending on which package manager CI or developers happen to run. This PR's yarn.lock and package-lock.json updates are consistent with each other, so it does not make the divergence problem worse, but the root cause remains unaddressed.
Suggestions
- The project ships both package-lock.json and yarn.lock. Relying on two competing lock files is a latent correctness risk — whichever package manager a developer or CI pipeline uses may produce different installs. Consider picking one (npm or yarn) and removing the other lock file to eliminate this ambiguity.
Automated review by dependabot[bot]'s agents
Bumps flatted from 3.3.3 to 3.4.2.
Commits
3bf09093.4.2885ddccfix CWE-13210bdba70added flatted-view to the benchmark2a02dce3.4.1fba4e8fMerge pull request #89 from WebReflection/python-fix5fe8648added "when in Rome" also a test for PHP53517adsome minor improvementb3e2a0cFixing recursion issue in Python tooc4b46dbAdd SECURITY.md for security policy and reportingf86d071Create dependabot.yml for version updatesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.