[playground] fix: don't show compilation spinner when toggling dark mode#10392
Open
JennyPng wants to merge 2 commits intomicrosoft:mainfrom
Open
[playground] fix: don't show compilation spinner when toggling dark mode#10392JennyPng wants to merge 2 commits intomicrosoft:mainfrom
JennyPng wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Collaborator
|
You can try these changes here
|
JennyPng
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
Contributor
|
No changes needing a change description found. |
| <link rel="og:image" type="image/svg+xml" href={baseUrl("/img/social.svg")} /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>typespec.io</title> | ||
| <script is:inline> |
Member
There was a problem hiding this comment.
intresting, I only seem to see this when switching from docs -> playground, do you see that in more places?
This seems like duplicate code f rom theme.ts so wondering here if we are maybe not missing an import somewhere or we can combine the logic at least
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the playground compilation spinner appears when the dark mode toggle is clicked, which doesn't seem desirable
When the dark mode toggle fires, WebsitePlayground re-renders and recreates imports (from .filter()) and importConfig ({ useShim: true }) as new object references
These are dependencies of the useEffect in useStandalonePlaygroundContext in
standalone.tsx, which re-runs the entire host creation and triggers the compile effect. So memoizing these to avoid thatchange to base-layout is because I noticed if I have dark mode, when switching pages, it briefly flashes to light mode before switching back to dark mode