Fix setsockopt signature to match standard socket API#319
Merged
mindflayer merged 3 commits intotypehints-and-docstringsfrom Feb 22, 2026
Merged
Fix setsockopt signature to match standard socket API#319mindflayer merged 3 commits intotypehints-and-docstringsfrom
setsockopt signature to match standard socket API#319mindflayer merged 3 commits intotypehints-and-docstringsfrom
Conversation
Co-authored-by: mindflayer <527325+mindflayer@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update signature to match standard API as per review feedback
Fix Feb 22, 2026
setsockopt signature to match standard socket API
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## typehints-and-docstrings #319 +/- ##
============================================================
- Coverage 99.06% 99.06% -0.01%
============================================================
Files 22 22
Lines 1074 1073 -1
============================================================
- Hits 1064 1063 -1
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@copilot add a test that covers the new line for when |
Co-authored-by: mindflayer <527325+mindflayer@users.noreply.github.com>
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



MocketSocket.setsockoptwas using(family, type, proto)— socket creation parameters — instead of the standardsocket.setsockopt(level, optname, value[, optlen])signature, making it a non-conforming mock.Changes
setsockopt(family, type, proto)→setsockopt(level, optname, value, optlen=None)_true_socketwith the correct arguments, handling both 3- and 4-argument call variantstest_setsockopt_without_optlenandtest_setsockopt_with_optlentotests/test_socket.pyto cover both forwarding paths🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.