Open
Conversation
Collaborator
Author
|
CircleCI caught this: Edit: fixed by moving the |
0b681ac to
6286c5d
Compare
Unfortunately these aren't supported by libuv directly, so we need to implement our own separate system. It doesn't need to be particularly scalable as the expected use-case is to send and receive ethernet frames. The server will listen on a Unix domain socket and receive connected SOCK_DGRAM sockets which will have ethernet frames on them. Signed-off-by: David Scott <dave@recoil.org>
6286c5d to
df53b9f
Compare
avsm
reviewed
Oct 10, 2022
| val setSocketTTL: Unix.file_descr -> int -> unit | ||
| (** [setSocketTTL s ttl] sets the TTL on the socket [s] to [ttl] *) | ||
|
|
||
| val cstruct_send: Unix.file_descr -> Cstruct.t -> int |
Collaborator
There was a problem hiding this comment.
I really would prefer to get these stubs into Cstruct_unix. It seems safe enough to put these alongside Cstruct_unix.of_fd
Collaborator
Author
There was a problem hiding this comment.
yeah makes sense, I'm about to write writev and readv too
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately these aren't supported by libuv directly, so we need to implement our own separate system. It doesn't need to be particularly scalable as the expected use-case is to send and receive ethernet frames.
The server will listen on a Unix domain socket and receive connected SOCK_DGRAM sockets which will have ethernet frames on them.
Signed-off-by: David Scott dave@recoil.org