Github action to build with dune package management#653
Open
gridbugs wants to merge 1 commit intomoby:masterfrom
Open
Github action to build with dune package management#653gridbugs wants to merge 1 commit intomoby:masterfrom
gridbugs wants to merge 1 commit intomoby:masterfrom
Conversation
This adds a dune lockdir to the project and a github action where pushing a tag causes a vpn binary distribution to be built for linux and macos, and released to the github "releases" page. Also fixes a few minor issues which prevented the project from building with the locked versions of dependencies. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Member
|
Nice! Any idea if this could also work for building a windows binary (ideally statically linked to help with distribution)? |
Collaborator
|
Thanks @gridbugs for the contribution! See quantifyearth/container-image#7 where I left some questions about the intended workflow of this new dev feature. |
Author
There's some more work needed in Dune to better support windows. Currently certain key packages including the OCaml compiler don't build on windows with package management. See ocaml/dune#11161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a dune lockdir to the project and a github action where pushing a tag causes a vpn binary distribution to be built for linux and macos, and released to the github "releases" page.
Also fixes a few minor issues which prevented the project from building with the locked versions of dependencies.