-
Notifications
You must be signed in to change notification settings - Fork 616
Use ReadOnlyMemory<byte> for binary data to eliminate UTF-16 transcoding #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
15
commits into
main
Choose a base branch
from
copilot/fix-binary-data-encoding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+373
−90
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7dca602
Initial plan
Copilot 4287694
Update protocol types to use ReadOnlyMemory<byte> for binary data
Copilot 8e6fcf0
Fix test files to work with new binary data representation
Copilot e405dfc
Add cache invalidation when Blob/Data properties are set
Copilot ebe3eef
Apply performance optimizations using MemoryMarshal.TryGetArray
Copilot 1d76c11
Use GetBytes overload with offset and count parameters
Copilot 39213fb
Use Base64.DecodeFromUtf8 to avoid string intermediate during decoding
Copilot a4ba4a9
Merge branch 'main' into copilot/fix-binary-data-encoding
ericstj b4e4eaf
Fix merge conflict with DebuggerDisplay
ericstj 61f0dfa
Cleanup refactoring
ericstj 5de847c
Remove string from DataContent conversion
ericstj dc01608
Add factory methods to data backed types to efficiently initialize fr…
ericstj 2fc35d9
Update some tests to use factory methods
ericstj 14fedca
Fix test assertions in McpServerToolTests
ericstj b3eacff
Merge branch 'main' of https://github.com/modelcontextprotocol/csharp…
ericstj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.