mcp: improve http transports error handling and make transport work with any size message #734
+118
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
91f93af to
ee3d418
Compare
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
ee3d418 to
85a4340
Compare
alexbumbacea
changed the title
Author
|
@findleyr current proposal (no fixed buffer size) approach is inline with most sdks. Can we get this merged? |
Contributor
|
@alexbumbacea sorry for the delay, will review tomorrow. |
findleyr
reviewed
Jan 10, 2026
jba
reviewed
Jan 10, 2026
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
85a4340 to
7ba1c9a
Compare
Author
|
@findleyr all comments have been either replied to or addressed. are there any other concerns? |
findleyr
reviewed
Jan 14, 2026
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
2 times, most recently
from
3577e96 to
377a108
Compare
findleyr
reviewed
Jan 15, 2026
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
377a108 to
8f634ce
Compare
Author
|
@findleyr is there anything else? |
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
8f634ce to
9fc710b
Compare
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
9fc710b to
9792dd9
Compare
Author
|
@findleyr can we get this merged? |
Contributor
|
@alexbumbacea very sorry, I thought I had merged this. Total oversight on my part. @maciej-kisiel we may want to cherry-pick this into the release, or do a second prerelease. |
findleyr
reviewed
Jan 27, 2026
Contributor
|
Apologies again for this getting lost in the weeds: I think there are a few things that need to be addressed before merging. |
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
b434d37 to
da1ac52
Compare
findleyr
reviewed
Jan 28, 2026
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
da1ac52 to
d534f57
Compare
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
d534f57 to
0416a3a
Compare
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
0416a3a to
636995a
Compare
findleyr
previously approved these changes
Feb 3, 2026
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
It looks like my comments were addressed. However could you please also address @maciej-kisiel's before we merge?
Thanks for this change, this is a good cleanup.
Co-authored-by: Maciej Kisiel <[email protected]>
alexbumbacea
force-pushed
the
handling-large-messages-and-surface-errors
branch
from
cfa78c5 to
3409d32
Compare
maciej-kisiel
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case for messages larger than 1MB, hence making this configurable would help.
In order to discover the source of our problems we had to spend some time investigating, as errors were silently discarded. So we also included changes to improving surfacing errors .