Skip to content

fix: skip tool output validation on error #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codefromthecrypt wants to merge 2 commits into from
+23 −1
Closed

fix: skip tool output validation on error #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ac8167
fix: skip tool output validation on error
codefromthecrypt Jan 27, 2026
d6fbce1
Merge branch 'main' into no-validate-error
codefromthecrypt Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/src/components/ToolResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const ToolResults = ({
const toolHasOutputSchema =
selectedTool && hasOutputSchema(selectedTool.name);

if (toolHasOutputSchema) {
if (toolHasOutputSchema && !isError) {
if (!structuredResult.structuredContent && !isError) {
validationResult = {
isValid: false,
Expand All @@ -125,6 +125,7 @@ const ToolResults = ({

let compatibilityResult = null;
if (
!isError &&
structuredResult.structuredContent &&
structuredResult.content.length > 0 &&
selectedTool &&
Expand Down
21 changes: 21 additions & 0 deletions client/src/components/__tests__/ToolsTab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,27 @@ describe("ToolsTab", () => {
expect(screen.getByText(/Validation Error:/)).toBeInTheDocument();
});

it("should skip output schema validation when tool result is an error", () => {
const errorResult = {
content: [{ type: "text", text: "error" }],
structuredContent: {
// Missing required field on purpose
},
isError: true,
};

renderToolsTab({
tools: [toolWithOutputSchema],
selectedTool: toolWithOutputSchema,
toolResult: errorResult,
});

expect(screen.queryByText(/Validation Error:/)).not.toBeInTheDocument();
expect(
screen.queryByText(/Valid according to output schema/),
).not.toBeInTheDocument();
});

it("should show error when tool with output schema doesn't return structured content", () => {
const resultWithoutStructured = {
content: [{ type: "text", text: "some result" }],
Expand Down