Skip to content

Conversation

@Kludex
Copy link
Member

@Kludex Kludex commented Jan 24, 2026

No description provided.

Comment on lines 141 to 148
from mcp.server.mcpserver import MCPServer

# Transport params in constructor
mcp = FastMCP("Demo", json_response=True, stateless_http=True)
mcp = MCPServer("Demo", json_response=True, stateless_http=True)
mcp.run(transport="streamable-http")

# Or for SSE
mcp = FastMCP("Server", host="0.0.0.0", port=9000, sse_path="/events")
mcp = MCPServer("Server", host="0.0.0.0", port=9000, sse_path="/events")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from mcp.server.mcpserver import MCPServer
# Transport params in constructor
mcp = FastMCP("Demo", json_response=True, stateless_http=True)
mcp = MCPServer("Demo", json_response=True, stateless_http=True)
mcp.run(transport="streamable-http")
# Or for SSE
mcp = FastMCP("Server", host="0.0.0.0", port=9000, sse_path="/events")
mcp = MCPServer("Server", host="0.0.0.0", port=9000, sse_path="/events")
from mcp.server.fastmcp import FastMCP
# Transport params in constructor
mcp = FastMCP("Demo", json_response=True, stateless_http=True)
mcp.run(transport="streamable-http")
# Or for SSE
mcp = FastMCP("Server", host="0.0.0.0", port=9000, sse_path="/events")

@@ -1,8 +0,0 @@
"""FastMCP - A more ergonomic interface for MCP servers."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing we don't want a backwards compatible shim since we'll be making breaking changes anyway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

```python
# Before (v1)
mcp = FastMCP("App", json_response=True)
mcp = MCPServer("App", json_response=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mcp = MCPServer("App", json_response=True)
mcp = FastMCP("App", json_response=True)

```

### `mount_path` parameter removed from FastMCP
### `mount_path` parameter removed from MCPServer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a section for the rename

"""Convert a result to a sequence of content objects.
Note: This conversion logic comes from previous versions of FastMCP and is being
Note: This conversion logic comes from previous versions of MCPServer and is being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: This conversion logic comes from previous versions of MCPServer and is being
Note: This conversion logic comes from previous versions of MCPServer (previously called FastMCP) and is being

very minor nit, probably easy to dismiss since we should remove this anyway

### Server

The FastMCP server is your core interface to the MCP protocol. It handles connection management, protocol compliance, and message routing:
The MCPServer server is your core interface to the MCP protocol. It handles connection management, protocol compliance, and message routing:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The MCPServer Server" is gonna get confusing.. didn't think about that before

mcp = FastMCP(
title="FastMCP Server",
mcp = MCPServer(
title="MCPServer Server",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"MCPServer Server" not super nice :/


model_config = SettingsConfigDict(
env_prefix="FASTMCP_",
env_prefix="MCP_",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth calling this out in migration docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll drop this Settings before the end of the refactor.

"""Create a FastMCP server for testing."""
server = FastMCP("test")
def mcpserver_server() -> MCPServer:
"""Create a MCPServer server for testing."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Create a MCPServer server for testing."""
"""Create an MCPServer server for testing."""

Should be "an" because MCPServer starts with an "em" sound.

"""Create a FastMCP server for testing."""
server = FastMCP("test")
def app() -> MCPServer:
"""Create a MCPServer server for testing."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Create a MCPServer server for testing."""
"""Create an MCPServer server for testing."""

@Kludex Kludex requested a review from maxisbey January 24, 2026 20:36
@claude
Copy link

claude bot commented Jan 24, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@claude
Copy link

claude bot commented Jan 24, 2026

Code review

Issues Found

Missing PR Description (CLAUDE.md violation)

The PR body is empty, which violates the CLAUDE.md requirement for pull requests:

Create a detailed message of what changed. Focus on the high level description of the problem it tries to solve, and how it is solved. Don't go into the specifics of the code unless it adds clarity.

This PR performs a significant breaking change (renaming FastMCP to MCPServer across 123 files). The PR description should explain:

  1. What problem the old naming caused or what improvement this provides
  2. Why MCPServer is a better name than FastMCP
  3. How this aligns with the project's direction and naming conventions

While the migration guide in docs/migration.md documents the technical changes, the PR description should provide the high-level rationale for reviewers and future reference.


Code Review Summary:

  • ✅ No bugs found
  • ✅ Breaking changes properly documented in docs/migration.md
  • ✅ All imports, class references, and tests updated consistently
  • ⚠️ PR description missing (CLAUDE.md violation)

@Kludex
Copy link
Member Author

Kludex commented Jan 24, 2026

Rude.

@Kludex Kludex merged commit 65c614e into main Jan 25, 2026
30 checks passed
@Kludex Kludex deleted the rename-fastmcp-to-mcpserver branch January 25, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants