fix(server): invoke onerror callback for all error responses#1725
Open
owendevereaux wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix(server): invoke onerror callback for all error responses#1725owendevereaux wants to merge 2 commits intomodelcontextprotocol:mainfrom
owendevereaux wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Previously, several error responses in StreamableHTTPServerTransport were returned without invoking the onerror callback, making it impossible to debug or log these errors. This change ensures all error responses call this.onerror() before returning, matching the existing pattern in validateRequestHeaders(). Error types now properly reported: - Accept header validation (406) - Content-Type validation (415) - JSON parse errors (400) - JSON-RPC message parse errors (400) - Session validation errors (400, 404) - Protocol version errors (400) - Initialization errors (400) - SSE stream conflicts (409) - Event store errors (400, 409, 500) Fixes modelcontextprotocol#1395
🦋 Changeset detectedLatest commit: 305a1d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1395
Several error responses in
WebStandardStreamableHTTPServerTransportwere returned without invoking theonerrorcallback, making it impossible to debug or log these errors.Problem
As reported in #1395, errors in nested try/catch blocks within
handlePostRequest,handleGetRequest, and validation methods were being silently swallowed. Theonerrorcallback was only invoked in the outermost catch block, so errors like:...were never reported via the callback, preventing any form of debugging.
Solution
Added
this.onerror?.(new Error(message))calls before allcreateJsonErrorResponsereturns, matching the existing pattern already used invalidateRequestHeaders().For parse errors, the original exception is preserved via
{ cause: e }:Error Types Now Reported
Testing
Build passes. The changes are straightforward additions of
onerrorcalls before existing error returns.