Conversation
Fixes issue 3630.
Fixes issue 3630.
maltelenz
approved these changes
Apr 23, 2026
Contributor
maltelenz
left a comment
maltelenz
left a comment
There was a problem hiding this comment.
Suggesting to use the more modern form with %{theThing}, but fine as is as well.
HansOlsson
approved these changes
Apr 23, 2026
Contributor
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Looks good to me.
I tried to search for textString=.*%[a-zA-Z]* and didn't find any similar ones, so I believe this suffices.
Co-authored-by: Malte Lenz <maltel@wolfram.com>
Co-authored-by: Malte Lenz <maltel@wolfram.com>
Contributor
Author
|
@maltelenz @HansOlsson I accepted the proposed change, but unfortunately your approvals are now stale. Please re-approve. |
maltelenz
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 3630.